Review stack: Studio-only media prompts + Bionic first-class support - #27
Open
TimofeySukh wants to merge 4 commits into
Open
TimofeySukh wants to merge 4 commits into
TimofeySukh wants to merge 4 commits into
Conversation
Rebased onto v3.0.0: the three SKILL.md edits moved with the library (skills/<category>/<slug>/SKILL.md -> library/skills/<slug>/SKILL.md), and the playbook safeDefaults rule moved from src/mcp/tools/project-tools.ts to src/core/capabilities/agent-playbook.ts with its regression test kept in src/mcp/tools/project-tools.test.ts.
Author
|
Update: codex/bionic-support (#13) is now PARKED by owner decision (2026-09-11) — deprioritized rather than blocked; the 3.1.0 agent-table port is not worth the effort right now. This stack ships WITHOUT Bionic as designed. If a Bionic merge commit ever appears on this branch from a background session, revert it — it is not part of this review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review stack — review/tim/mcp-2026-09-11
@mathias-heide — ready for review.
Excluded from this stack:
codex/bionic-support(#13) — needs a rebase/port onto the 3.1.0 agent-table architecture before it can stack (verified: 13-file semantic conflict, see below).Why #13 is excluded
Its merge into current
main(which carries the 3.1.0 agent-table refactor, PR #24) is not mechanically resolvable: #13 was built against the pre-3.1.0 architecture and re-adds the old hardcodedsupportedAgentslist, alias map,skill-locationsswitch, and label switch that main deleted in favor ofsrc/installer/agent-table.ts. Independently reproduced: trial merge conflicts in 13 files (README, CHANGELOG, docs/OVERVIEW, docs/SETUP_PROMPT, docs/SKILLS, integrations/README, package.json, setup.ts, skills.ts, skills-registry.ts, agent-config.ts, skill-locations.ts, version-check.ts); e.g.setup.tsHEAD side importsagentLabelfromagent-table.jswhile #13 re-introduces the deleted hardcodedAGENT_LABELrecord. Every candidate resolution requires porting Bionic into the new agent-table design — new logic, not additive union. #13 needs a rebase/port onto the 3.1.0 agent-table architecture as its own follow-up.Verification on the combined stack (current main + #12)
origin/main(40bf15f, includes fix(skills): descriptions fit the hosts' skills context budget #31 skill-description-budget): merge clean exceptregistry/generated/index.json(generated file, both sides touched it) — resolved by running the repo's ownnpm run generate:registryon the merged sources; no other conflicts, no manual source resolution.npm installOK;npx tsc --noEmitclean;npx vitest run: 1480 passed / 10 skipped (105 files);npm run validate:library: 208 resources valid, 0 errors;npm run generate:registry+git diff --exit-code registry/generated— no registry drift (regenerated file carried inside the main-update merge commit, no separate chore commit needed).