Remove obsolete bundled agent skills - #129
Conversation
- Delete redundant Convex and UI skill packages from the repository
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis change removes obsolete bundled agent/editor skills and generated Convex guidance, then adds repository-owned vocabulary and a page-scoped cloud-sync implementation and delivery guide. The new documentation links resolve, and the TypeScript and diff-whitespace checks pass. However, the handoff’s required Flutter tests, analysis, and visible client launches cannot start because the documented Confidence Score: 3/5Not ready to merge until the cloud-sync handoff provides an executable Flutter/FVM setup path or uses the repository-supported Flutter command. The documented Flutter test, analysis, and launch commands were executed and consistently failed because Files Needing Attention: docs/cloud_sync_refactor/server_side_sync_boundaries_handoff.md and docs/cloud_sync_refactor/server_side_sync_boundaries_delivery.md need a documented FVM/SDK bootstrap prerequisite or corrected Flutter invocations.
What T-Rex did
|
| fvm flutter test \ | ||
| test/strategy_page_session_provider_test.dart \ | ||
| test/strategy_op_queue_provider_test.dart \ | ||
| test/collab_sync_models_test.dart \ | ||
| test/cloud_ui_parity_helpers_test.dart \ | ||
| test/strategy_integrity_test.dart | ||
| PASS, 55 tests |
There was a problem hiding this comment.
Required FVM commands cannot run
The handoff makes fvm flutter mandatory for the focused tests, full Flutter suite, analyzer, and the delivery runbook’s macOS and Chrome clients, but it does not provide an FVM installation or SDK-bootstrap prerequisite. In the repository environment, both fvm and global flutter are unavailable, so each required command exits with fvm: not found before validation or a client launch begins. The repository has a local Flutter SDK and .fvmrc, but contributors following this new handoff have no documented way to make the required command available. Add an explicit FVM/bootstrap step or use the repository-supported Flutter invocation consistently.
Summary
Testing