Skip to content

Add stable cloud beta automation hooks - #131

Merged
SunkenInTime merged 3 commits into
icarus-cloudfrom
cloud-beta/automation-semantics
Aug 25, 2026
Merged

Add stable cloud beta automation hooks#131
SunkenInTime merged 3 commits into
icarus-cloudfrom
cloud-beta/automation-semantics

Conversation

@SunkenInTime

Copy link
Copy Markdown
Owner

Summary

  • give auth fields and actions stable automation keys and accessible labels
  • give every library rail destination and the account action stable keys and semantics
  • stack auth actions vertically so large text and deterministic UI automation do not overflow

Verification

  • fvm flutter test test/widgets/cloud_beta_automation_semantics_test.dart
  • fvm flutter analyze
  • fvm flutter test (321 tests)
  • fvm flutter build web --no-wasm-dry-run --no-tree-shake-icons
  • git diff --check

Manual path

  1. Open Icarus signed out and choose Log In.
  2. Verify email/password, mode switch, Discord, and submit controls remain usable at large text sizes.
  3. Enable the browser accessibility tree and locate library-local, library-cloud, library-shared, library-community, and library-account-action by their labels.

The running web client was also smoke-tested after a hot restart. An existing signed-in session exposed a separate Convex protocol blocker (baseVersion missing); this PR does not enter the sync-boundary work already in flight.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f4c2685-1228-48c7-9f42-2424506dfdd9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This change makes cloud beta controls easier to locate with automation and assistive technologies. Authentication fields and actions now have stable keys and labels, auth actions are stacked vertically, and library destinations and account actions expose explicit control semantics.

Source inspection shows the existing sign-in, sign-up, and navigation callbacks remain connected. The focused widget tests could not render because the available Flutter SDK cannot compile lucide_icons_flutter 3.1.9.

T-Rex validation blocked

package: lucide_icons_flutter 3.1.9 subclasses Flutter's now-final IconData when compiled with the available Flutter 3.44.4 SDK. The focused authentication and library-rail widget tests stopped during dependency compilation, before any widget assertions or interaction checks could run. Configure VMs

Confidence Score: 2/5

The code preserves the intended callback wiring, but merge confidence is limited until the focused Flutter widget tests can compile and run.

Source inspection confirms that the email and Discord actions retain their handlers and busy guards, sign-up confirmation remains wired to the sign-up path, and rail semantics retain unique labels and activation callbacks. The available test environment fails before widget rendering, so these user-visible behaviors were not executed.

Files Needing Attention: lib/widgets/dialogs/auth/auth_dialog.dart, lib/widgets/folder_navigator.dart, and test/widgets/cloud_beta_automation_semantics_test.dart should be rechecked with a Flutter SDK and lucide_icons_flutter version that compile together.

T-Rex T-Rex Logs

What T-Rex did

  • Validated that the vertically arranged authentication buttons retain their Discord and email-password handlers and their busy-state guards.
  • Confirmed the library rail exposes distinct identifiers and labels for local, cloud, shared, community, and account controls, and that semantics nodes forward the existing actions.
  • Documented the sign-up flow: the sign-up branch conditionally displays the confirmation field, validates matching passwords, and routes submission through the sign-up path.
  • Observed the auth action controls use separate ShadButton widgets with the expected onPressed logic, and noted a test load failure caused by a Flutter icon-data compatibility issue (lucide_icons_flutter) during dependency compilation.
  • Noted that runtime validation is blocked by a dependency/toolchain incompatibility, with failure artifacts detailing the exact command, directory, exit code, and compiler output.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (3): Last reviewed commit: "Merge auth field semantics into editable..." | Re-trigger Greptile

Comment thread lib/widgets/folder_navigator.dart
@SunkenInTime

Copy link
Copy Markdown
Owner Author

@greptileai

Comment thread lib/widgets/dialogs/auth/auth_dialog.dart Outdated
@SunkenInTime

Copy link
Copy Markdown
Owner Author

@greptileai

@SunkenInTime

Copy link
Copy Markdown
Owner Author

The latest Greptile failure is an environment mismatch, not an unresolved code finding.

Evidence for exact head 89c81fb6ac83106a87809350c324fd24a882ab78:

  • validate run 32814644721 passed Analyze, Build Web Client, and Run Tests.
  • .fvmrc pins Flutter 3.41.1; the review report used Flutter 3.44.4.
  • fvm flutter test test/widgets/cloud_beta_automation_semantics_test.dart passes and now asserts exactly one editable semantics node per visible auth field.
  • The full local suite passes (321 tests).
  • Both actionable Greptile threads are resolved on this head.

I am not changing the repository dependency/toolchain contract to accommodate the reviewer VM.

@SunkenInTime
SunkenInTime changed the base branch from cloud-beta/web-client to icarus-cloud August 25, 2026 06:25
@SunkenInTime
SunkenInTime merged commit 83c102f into icarus-cloud Aug 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant