Skip to content

refactor(web): unify floating event forms#1892

Closed
tyler-dane wants to merge 1 commit into
mainfrom
refactor/unify-floating-event-forms
Closed

refactor(web): unify floating event forms#1892
tyler-dane wants to merge 1 commit into
mainfrom
refactor/unify-floating-event-forms

Conversation

@tyler-dane

Copy link
Copy Markdown
Contributor

Summary

  • replace Day's module-level floating stores with a local Floating UI controller shared by Day and Week
  • render both calendar forms through one floating shell with declarative reference refs
  • give the Day context menu independent virtual positioning and remove timer/DOM lookup reopening logic

Why

Day and Week had separate form-positioning lifecycles, while Day also coordinated form and context-menu state through five external stores. This makes open/close behavior local, explicit, and consistent with Floating UI's controlled-state and ref APIs.

Validation

  • bun test:web — 1,050 tests passed
  • bun type-check
  • bun lint — passes with 13 pre-existing warnings
  • React Doctor changed-file scan — 91/100, no issues found

@tyler-dane tyler-dane closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant