Skip to content

[docs] Improve Menu builder #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loic425 merged 1 commit into from
Apr 17, 2026
Merged

[docs] Improve Menu builder #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Menu/AdminMenuBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#[AsDecorator(decorates: 'sylius_admin_ui.knp.menu_builder')]
final class AdminMenuBuilder implements MenuBuilderInterface
{
public function __construct(private MenuBuilderInterface $menuBuilder)
public function __construct(private readonly MenuBuilderInterface $menuBuilder)
{
}

Expand Down
6 changes: 3 additions & 3 deletions docs/cookbook/admin_panel/menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ use Symfony\Component\DependencyInjection\Attribute\AsDecorator;
final readonly class MenuBuilder implements MenuBuilderInterface
{
public function __construct(
private readonly FactoryInterface $factory,
private readonly MenuBuilderInterface $menuBuilder,
) {
}

public function createMenu(array $options): ItemInterface
{
$menu = $this->factory->createItem('root');
$menu = $this->menuBuilder->createMenu($options);

$menu
->addChild('dashboard', [
Expand Down Expand Up @@ -66,7 +66,7 @@ final readonly class MenuBuilder implements MenuBuilderInterface

public function createMenu(array $options): ItemInterface
{
$menu = $this->factory->createItem('root');
$menu = $this->menuBuilder->createMenu($options);
// ...
$this->addLibrarySubMenu($menu);

Expand Down
Loading