Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug that results in duplicate, structurally equivalent implicit
Subsettingrelationships targeting feature chains.Background
ReferenceUsageAdapter#addDefaultGeneralType()creates an implicitSubsettingfrom the second input parameter of a triggeredTransitionUsageto:Previously, the guard in
TypeAdapter#isImplicitSpecializationFor()relied onList.contains()and therefore compared the rootFeatureinstances representing the chains. SinceFeatureUtil.chainFeatures()creates a newFeatureinstance on every call, an existing structurally equivalent chain was not detected. Two equivalent implicitSubsettingscould consequently be stored inimplicitGeneralTypes.These duplicates could later be materialized as separate relationships by
TypeUtil.insertImplicitSpecializations().Changes
Update
TypeAdapter#isImplicitSpecializationFor()to structurally compare feature chains used as general types of implicit relationships.