Repository navigation
Two doc corrections, a hostinfo test fix, and /api/requests tests - #9
Merged
Merged
Conversation
The API reads `since` (epoch seconds) and `limit` (default 1000); it does not take a `range` param, so a range request is silently ignored. The test_hostinfo platform gates skip three Windows-only tests on Linux, not two.
rss_gb is rounded to 2 dp in GB, so a tiny launcher/wrapper process that matches an engine name reports 0.0 and tripped the `> 0` assertion on the GPU box. Allow >= 0 for the matched processes in both Linux process tests.
Pin the documented params: default since=0/limit=1000, explicit since/limit pass-through, and the 400 for a non-integer value or limit < 1.
T-Crypt
marked this pull request as ready for review
October 17, 2026 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quality pass over the repo. Two README claims contradicted the code, one
collector test failed on the GPU box, and the
/api/requestsendpoint had nounit test.
Docs
/api/requests?range=…. The handler readssince(epoch seconds) andlimit(default 1000, clamped to 1000), so arange=…request is ignored and returns unfiltered rows. The table row nowreads
?since=…&limit=….test_hostinfo.pyskips". The Windows ctypesbackend holds three tests, so a Linux run skips three. The sentence now
describes the gates with no count.
Tests
collector/test_hostinfo.py:test_processes_shapefailed on the GPU boxwhen a tiny launcher process matched an engine name.
rss_gbis rounded to2 dp in GB, so a process of about 2 MB reports
0.0, which failed the> 0assertion. Both Linux process tests now accept
>= 0.collector/test_speculum.py: three tests for the/api/requestscontract.They pin the default (
since0,limit1000), the explicit pass-through,and the 400 for a non-integer value or
limit < 1.Test output
The repo and CI configure no linter. The documented parse check is
py_compile.flake8 --select=E9,F63,F7,F82 collector/is clean.Issues
gh issue list --state allis empty. The repo has no open or closed issues,so there was nothing to triage.
No dependency changes and no drive-by refactors.