Fix CleanupRefactoring queuing duplicate rewrites for the same node - #177
Merged
Merged
Conversation
FrancescoPezzella
marked this pull request as draft
September 11, 2026 15:20
FrancescoPezzella
force-pushed
the
fix-cleanup-refactoring-dupe
branch
from
September 11, 2026 15:57
6d6a160 to
66b2132
Compare
FrancescoPezzella
marked this pull request as ready for review
September 14, 2026 09:28
Collaborator
|
@rcorvino The root cause of this issue is your change on line 15 of renaissance/recipes/cleanup_refactoring.py - refs = flatten(find_ast_type(n, VariableDef) for n in find_ast_type(ast_refactor.node, CompoundStatement))
+ refs = flatten(
+ find_semantic_kind(n, SemanticKind.DECLARATION) for n in find_semantic_kind(ast_refactor.node, SemanticKind.STATEMENT)
+ )As after this change a declaration will be added twice - once as part of the compound statement (that is the body of a function) and once as part of the declaration statement. When navigation to the parent would be available, one can check for the direct containment and solve the problem. |
FrancescoPezzella
force-pushed
the
fix-cleanup-refactoring-dupe
branch
3 times, most recently
from
September 23, 2026 08:30
2982691 to
9461a89
Compare
Collaborator
Author
|
any update? |
FrancescoPezzella
force-pushed
the
fix-cleanup-refactoring-dupe
branch
from
September 23, 2026 13:23
9461a89 to
3e3cfc5
Compare
pjljvandelaar
approved these changes
Sep 23, 2026
pjljvandelaar
left a comment
pjljvandelaar
left a comment
Collaborator
There was a problem hiding this comment.
Good for now - we will revisit when making an explicit textRewriter and ASTRewriter.
FrancescoPezzella
added a commit
that referenced
this pull request
Sep 24, 2026
FrancescoPezzella
added a commit
that referenced
this pull request
Sep 25, 2026
FrancescoPezzella
added a commit
that referenced
this pull request
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#176