Repository navigation
Fix/type alias semantic kind - #263
Merged
Merged
Conversation
PYTHON_KIND_MAP had no entry for TypeAlias, so a type alias statement fell through to SemanticKind.NODE on the ast-based backends. Recipes that select statements by semantic kind silently skipped type aliases. Hypothesis found this through test_from_cst_returns_statement. The tree-sitter backend already reports type_alias_statement as a statement, so this also restores agreement between backends. Added a deterministic test so the regression does not depend on Hypothesis rediscovering the input.
Enumerates all ast.stmt subclasses and fails when any falls through to SemanticKind.NODE, so a future grammar addition cannot slip through unclassified. Raises the S101 budget by one for the new assert. Solves issue 262.
Signed-off-by: pjljvandelaar <pierre.vandelaar@tno.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #262