1627 facilities in nav bar menu - #1628
Open
phycodurus wants to merge 15 commits into
Open
Conversation
with the new AppConfig.observation_facilities() integration point. So, facility.get_service_classes collects facilities from the new integration point and `settings.TOM_FACILITY_CLASSES` combined.
phycodurus
changed the title
jchate6
requested changes
Jul 28, 2026
jchate6
left a comment
jchate6
left a comment
Contributor
There was a problem hiding this comment.
Resolving this issue would greatly help with the review of this PR.
TOMToolkit/tom_demoapp#30
Member
Author
jchate6
requested changes
Jul 31, 2026
jchate6
left a comment
jchate6
left a comment
Contributor
There was a problem hiding this comment.
The comments and doc strings need to be cleaned up.
Many of the tests are not useful and just more code that needs to be maintained.
We should not rely on a URL in the app config. Just pass this information from the class.
this is better than having it be an integration point dictionary item
in anticipation of Facility model with list- and detail views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration point (
AppConfig.observation_facilities()which is analogous to thedata_services()integration point) for facilities with general, non-Target-specific functionality that should be presented on a "facility" index page (not a TargetDetail page, b/c it's not specific to a Target). Facilities that implement the integration point:Closes