fix(sync): restore the push completion log to a single OSLog literal - #1995
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaks the build on
main.Problem
macOS App Testsfails at compile with exit 65:Introduced by 6276f1b (#1990).
TableProCore Package Testspassed because that target does not include this file.Cause
os.Logger.info(_:)takes anOSLogMessage, which the compiler builds from a single string literal with interpolation. The push completion message was split across two literals joined with+, so Swift evaluated the concatenation first and passed a plainString.Fix
Pull the three counts into locals so the message fits one literal within the 120-char width. The logged text is unchanged.
Grepped the repo for the same shape (a
+ "..."continuation inside anylogger.*call); this was the only one.No CHANGELOG entry: #1990 is itself still under
[Unreleased], and CLAUDE.md says to fold such fixes into the existing entry rather than add a "Fixed" line. No test: no behaviour change, and a compile error cannot be covered by one.