Skip to content

revert(editor): put query history back in the bottom drawer - #2898

Merged
datlechin merged 1 commit into
mainfrom
revert/query-history-bottom-drawer
Sep 15, 2026
Merged

datlechin merged 1 commit into
mainfrom
revert/query-history-bottom-drawer

Conversation

@datlechin

Copy link
Copy Markdown
Member

Puts query history back under the editor and results, where it was before #2892.

#2892 moved it into the window's trailing pane as a third TrailingPaneSurface beside the inspector
and the assistant. Seen running, that is worse than the drawer it replaced, and this reverts it.

Why the drawer is the right home

A query and its history are the same shape: wide and short. The drawer gave the entry list and the
detail pane the full width of the window, side by side. The trailing pane is a 270pt column, so
fitting the same two panes there meant stacking them, and both halves then got a third of the
reading width for no gain.

It also made history exclusive with the inspector. The trailing pane shows one surface at a time, so
opening history closed the row inspector and persisted that choice for the connection. Under the
drawer the two are independent, which is what someone comparing a past query against the row in
front of them actually needs.

What this restores

  • The outer VerticalCollapsibleSplitView in MainEditorContentView, with the drawer autosaved per
    connection under SplitViewAutosaveName.historyDrawer.
  • HistoryPanelView's list beside its detail, at its original 260 + 280 minimums and its original
    autosave name, rather than list stacked over detail.
  • toggleHistoryPanel() driving HistoryPanelState.isVisible directly.
  • TrailingPaneSurface back to inspector and assistant, with WorkspacePanes,
    TrailingPaneProxy, TrailingPaneUnavailableView and MainSplitViewController following.

Three fixes from #2895 go with it, because they only existed to make the trailing-pane version
behave: the revealInspectorForSelection history guard, syncHistoryPanelVisibility() and its call
sites, and the TrailingPaneState migration that adopted .history for a connection whose drawer
was open. With the drawer back, HistoryPanelState.isVisible is once again the only thing that says
whether history is showing, so none of the three has anything to reconcile.

Everything else from #2892 and #2895 stays: the pure QueryResultPresentation and
QueryCommandAvailability models, the editor command bar, the result chooser in the status bar, and
the seven non-history review fixes.

Verification

  • verify.sh build: PASS
  • verify.sh test QueryResultPresentationTests QueryCommandAvailabilityTests ResultSetPolicyTests ResultStatusBarLayoutTests: PASS, 99 executed, 99 passed
  • verify.sh lint TablePro: PASS, 0 violations
  • verify.sh docs: PASS

Checked by hand in a Debug build against the sample database: Cmd+Y opens the drawer under the
results with its list and detail side by side, the divider resizes it, and the inspector is
unaffected by opening it.

docs/features/query-history.mdx goes back to describing the drawer, and the two CHANGELOG entries
that announced the move are removed rather than replaced: #2892 is unreleased, so the move never
shipped and there is nothing for a reader to be told about.

@mintlify

mintlify Bot commented Sep 15, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
TablePro 🟢 Ready View Preview Sep 15, 2026, 11:57 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@datlechin
datlechin merged commit 1d66e0d into main Sep 15, 2026
9 checks passed
@datlechin
datlechin deleted the revert/query-history-bottom-drawer branch September 15, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant