revert(editor): put query history back in the bottom drawer - #2898
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puts query history back under the editor and results, where it was before #2892.
#2892 moved it into the window's trailing pane as a third
TrailingPaneSurfacebeside the inspectorand the assistant. Seen running, that is worse than the drawer it replaced, and this reverts it.
Why the drawer is the right home
A query and its history are the same shape: wide and short. The drawer gave the entry list and the
detail pane the full width of the window, side by side. The trailing pane is a 270pt column, so
fitting the same two panes there meant stacking them, and both halves then got a third of the
reading width for no gain.
It also made history exclusive with the inspector. The trailing pane shows one surface at a time, so
opening history closed the row inspector and persisted that choice for the connection. Under the
drawer the two are independent, which is what someone comparing a past query against the row in
front of them actually needs.
What this restores
VerticalCollapsibleSplitViewinMainEditorContentView, with the drawer autosaved perconnection under
SplitViewAutosaveName.historyDrawer.HistoryPanelView's list beside its detail, at its original 260 + 280 minimums and its originalautosave name, rather than list stacked over detail.
toggleHistoryPanel()drivingHistoryPanelState.isVisibledirectly.TrailingPaneSurfaceback toinspectorandassistant, withWorkspacePanes,TrailingPaneProxy,TrailingPaneUnavailableViewandMainSplitViewControllerfollowing.Three fixes from #2895 go with it, because they only existed to make the trailing-pane version
behave: the
revealInspectorForSelectionhistory guard,syncHistoryPanelVisibility()and its callsites, and the
TrailingPaneStatemigration that adopted.historyfor a connection whose drawerwas open. With the drawer back,
HistoryPanelState.isVisibleis once again the only thing that sayswhether history is showing, so none of the three has anything to reconcile.
Everything else from #2892 and #2895 stays: the pure
QueryResultPresentationandQueryCommandAvailabilitymodels, the editor command bar, the result chooser in the status bar, andthe seven non-history review fixes.
Verification
verify.sh build: PASSverify.sh test QueryResultPresentationTests QueryCommandAvailabilityTests ResultSetPolicyTests ResultStatusBarLayoutTests: PASS, 99 executed, 99 passedverify.sh lint TablePro: PASS, 0 violationsverify.sh docs: PASSChecked by hand in a Debug build against the sample database:
Cmd+Yopens the drawer under theresults with its list and detail side by side, the divider resizes it, and the inspector is
unaffected by opening it.
docs/features/query-history.mdxgoes back to describing the drawer, and the two CHANGELOG entriesthat announced the move are removed rather than replaced: #2892 is unreleased, so the move never
shipped and there is nothing for a reader to be told about.