Repository navigation
feat(data-grid): zoom the focused grid's font with Cmd+= and Cmd+- - #3770
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd+=,Cmd+-) act on the area with focus, through the responder chain: a diagram zooms itself, a data grid changes the Data Grid font size, anything else changes the editor font size as before.DataGridScrollViewanswers both commands for everyDataGridView: table and query results, Structure, Create Table, Compare, data file windows. It sits on the scroll view rather than the table because a cell being edited is mounted on the scroll view.FontSizeZoomholds the one stepping rule the editor and grid share.Cmd+0is Show Sidebar, and a font has no actual size other than the one Settings holds.EditorZoomTestsis nowFontSizeZoomTests; its enablement case callsFontSizeZoom.editor.enablementin place of the removedMainSplitViewController.zoomEnablement.Docs: TableProApp/docs#115
Test plan
DataGridZoomCommandTests(hosted, realDataGridView): the chain from a focused grid and from a cell editor reachesDataGridScrollViewbefore the window; zoom changes only the grid size; the items dim at both limits; rows grow with the font; an open editor with typed text survives a zoom that widens the row-number column and grows the rows. On main the grid has no responder, so the chain ends at the window.FontSizeZoomTests,DataGridRowHeightTests, and neighbours:DiagramZoomCommandTests,MenuValidationCoverageTests,CellOverlay*,DataGrid*suites.Refs #2526