Repository navigation
Conversation
…tabase from the editor bar
…kHouse, Cassandra and MongoDB
…y opening its session there
…linux-workspace-follows-tab-database
…e it in the window
…t database's session
…where a connection reaches several
…or-database-switch # Conflicts: # linux/crates/app/src/ui/editor/tab_scope.rs # linux/data/resources/ui/sql-editor.ui
…lete only where the catalog reaches
…or-database-switch-more # Conflicts: # linux/crates/app/src/ui/editor/editor_session_slot.rs # linux/crates/core/src/dialect/sql_dialect.rs # linux/crates/drivers/mongodb/src/dialect.rs
… tabs with each driver's own means
…-editor-database-switch-reconnect # Conflicts: # linux/crates/app/src/ui/editor/editor_session_slot.rs # linux/crates/core/src/dialect/sql_dialect.rs # linux/crates/drivers/mongodb/src/dialect.rs # linux/crates/drivers/postgres/src/dialect.rs
…rough the slot's one move
…nux-editor-follows-database-session
…nux-editor-follows-database-session
…nux-editor-follows-database-session
…nux-editor-follows-database-session
…ion's disconnect, and purge one only after its drafts land
…joins, and leave the sidebar's selection to the tab in front
…wn database, and offer one when none is open
…or-database-switch-more
…-editor-database-switch-reconnect
…linux-workspace-follows-tab-database
…nux-editor-follows-database-session # Conflicts: # linux/crates/app/src/ui/editor/tab_scope.rs
…-editor-database-switch-reconnect
…linux-workspace-follows-tab-database
…nux-editor-follows-database-session
…or-database-switch-more
…-editor-database-switch-reconnect
…linux-workspace-follows-tab-database
…nux-editor-follows-database-session
…follows-tab-database
…nux-editor-follows-database-session
datlechin
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3902.
Summary
USE, brings that database's session into the window, and its completion reads that session's catalog: the right tables on PostgreSQL and SQL Server too.Test plan
session_window::tests::sessions:an_editor_tab_moved_to_a_database_opens_its_session,tabs_moved_while_a_database_opens_all_read_its_catalog.ui::editor::tests::completion_reads_only_the_session_of_the_tabs_database.verify.shbuild,tableproeditor and session window tests, lint.