Repository navigation
fix(tabs): keep a table tab's rows until you reload it (#3848) - #3921
Merged
Merged
Conversation
(cherry picked from commit fcc7073)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick of #3848.
Summary
isEvicted,evict(for:),QueryTab.loadEpoch,discardRowsKeepingMetadataorMemoryPressureAdvisor.ParkedTableLoad, the sharedholdsUnsavedWorkand thecanEditActiveResultbusy gate come over as on main.pruneGridDisplayCachesat the switch. ItsdisplayStateCachealready prunes itself on insert; that prune now usesGridDisplayCacheBudgetinstead of the pressure-halvedMemoryPressureAdvisorbudget.holdsUnsavedWorkmatches the change manager to the selected tab (0.83 has nochangeManagerTabId) and counts an open cell throughhasOpenCellOverlay, the check 0.83's refresh plan already used (noisEditingActiveGrid).FindBarView'srowsRevisiondropsloadEpoch; only eviction moved it.handleWindowDidResignKey.changedTableWaitsForAnOpenCellopens a realCellOverlayViewerinstead of main'sDataGridMountedViewstub.TableTabRowRetentionTestschecksdisplayStateCacheinstead of grid model caches; the switching case is a contract test here, since 0.83 has no deferred prune to wait on.rowsAreReadOnlyWhileReplacedcheckscanEditActiveResultonly (0.83 has nogridConfiguration(for:)).3848.*.md.Test plan
verify.sh build: PASSverify.sh test: 242 executed, 242 passed, 0 failed, over the 20 suites fix(tabs): keep a table tab's rows until you reload it #3848 touched or that read the changed code (TableTabRowRetentionTests,MainContentCoordinatorLazyLoadTests,CatalogChangeWindowTests,MainContentCoordinatorTabSwitchTests,TableRowsRefreshPlanTests,MaterializedViewRowWriteTests,GridDisplayCacheBudgetTestsand others)rowsAreReadOnlyWhileReplacedandchangedTableWaitsForAnOpenCellassert the two gatesrelease/0.83lacks (the busy edit gate, the open cell incanAutoLoadTableTab). Not run against the unfixed branch.verify.sh linton the 32 changed Swift files: PASS, 0 violationsFixes #3841