Skip to content

feat(about): thank license holders by name in the About panel - #3923

Merged
datlechin merged 2 commits into
mainfrom
feat/about-supporters
Oct 30, 2026
Merged

datlechin merged 2 commits into
mainfrom
feat/about-supporters

Conversation

@datlechin

Copy link
Copy Markdown
Member

Summary

  • The About panel's credits list, under "Thanks to these license holders", the people who bought a license and said yes by email to being named. With nobody listed the credits are unchanged.
  • apple/TablePro/Resources/Supporters.json is the only copy of the list. A name goes in or comes out through a pull request, spelled the way its owner gave it. It ships empty; names follow once buyers answer.
  • AboutPanelCredits moves out of AppDelegate+MainMenuActions.swift into its own file with the list's loader. A missing or unreadable file logs and shows no names, rather than failing the panel.
  • The heading is translated for fr, ko, tr, vi, zh-Hans and zh-Hant through Xcode's export and import.
  • Monetization roadmap task R1.7 (tablepro-cloud docs/monetization-roadmap.md).

Test plan

  • AboutPanelCreditsTests: names follow the project links, an empty list adds nothing, blank entries and stray spaces are dropped, and the shipped Supporters.json decodes. 4 cases pass with verify.sh test; lint is clean.

@datlechin
datlechin enabled auto-merge (squash) October 30, 2026 18:37
@datlechin
datlechin merged commit 99e1653 into main Oct 30, 2026
8 checks passed
@datlechin
datlechin deleted the feat/about-supporters branch October 31, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant