Skip to content

fix: upgrade shell-quote to 1.8.4 (CVE-2026-9277) #11151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix: upgrade shell-quote to 1.8.4 (CVE-2026-9277) #11151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,10 @@
"typescript60": "npm:typescript@6.0.1-rc",
"vite": "^6.4.1",
"vitest": "^4.0.18"
},
"pnpm": {
"overrides": {
"shell-quote": "1.8.4"
}
Comment on lines +88 to +92

@coderabbitai coderabbitai Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n -C 2 'shell-quote|overrides' package.json pnpm-lock.yaml

if rg -n 'shell-quote: 1\.8\.3|shell-quote@1\.8\.3' pnpm-lock.yaml; then
  echo "Stale shell-quote 1.8.3 resolution found" >&2
  exit 1
fi

Repository: TanStack/query

Length of output: 1591

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "package.json override section:"
sed -n '85,93p' package.json

echo
echo "pnpm-lock overrides section:"
sed -n '7,11p' pnpm-lock.yaml

echo
echo "pnpm-lock nested shell-quote@1.8.3 dependency references:"
python3 - <<'PY'
import re
with open('pnpm-lock.yaml', encoding='utf-8') as f:
    text = f.read()
for key in re.findall(r'(?:^ {4}|^ {6})dependencies:\s*\n(?:[^:]+:\s*\n)*\s{8,}shell-quote:\s*([^\s\n]+)', text, flags=re.M):
    print(key)
PY

echo
echo "pnpm-lock shell-package version labels:"
python3 - <<'PY'
import re
with open('pnpm-lock.yaml', encoding='utf-8') as f:
    for i, line in enumerate(f, 1):
        if re.match(r'\s+shell-(?:command-for-windows|shell-quote)@\d+\.\d+\.\d+:', line):
            print(f'{i}: {line.strip()}')
PY

Repository: TanStack/query

Length of output: 592

Regenerate pnpm-lock.yaml for this override.

package.json pins shell-quote to 1.8.4, but pnpm-lock.yaml still has no matching override and still resolves shell-quote to 1.8.3. Keep the committed dependency graph consistent so frozen-lockfile installs do not fail and the pinned version applies transitively.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` around lines 88 - 92, Regenerate pnpm-lock.yaml after the
pnpm.overrides configuration in package.json pins shell-quote to 1.8.4. Ensure
the lockfile records the matching override and resolves all transitive
shell-quote entries to 1.8.4, preserving a frozen-lockfile-compatible dependency
graph.

}
}