fix(svelte-query): shrink useMutationState results - #11153
Open
alex-js-ltd wants to merge 3 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesMutation filter result updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #11152.
useMutationState()in@tanstack/svelte-queryonly ever grew its returnedarray. The cache-subscription callback updated the underlying
$statearraywith
Object.assign(result, nextResult), butArray.prototype.lengthisnon-enumerable, so
Object.assignnever truncatesresultwhen the newresult set is shorter. Once a mutation stopped matching
filters(settled,was removed/GC'd, or a narrower filter was applied), its stale entry stayed
in the array forever.
Fix: replace the
Object.assignwithresult.splice(0, result.length, ...nextResult),which replaces the array's contents in place — including truncating it —
while preserving the
$statearray's reference identity (required by the rune).Includes a regression test that starts two mutations matching
filters: { status: 'pending' }, lets both settle, and asserts the returnedarray goes back to
[]instead of keeping the two stale"pending"entries.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
useMutationStateso mutations are removed from filtered results when they no longer match the selected criteria.Tests