Skip to content

docs: redirect flat reference URLs broken by the TypeDoc migration - #11379

Merged
sukvvon merged 2 commits into
mainfrom
docs/redirect-flat-reference-urls
Sep 3, 2026
Merged

docs: redirect flat reference URLs broken by the TypeDoc migration#11379
sukvvon merged 2 commits into
mainfrom
docs/redirect-flat-reference-urls

Conversation

@sukvvon

@sukvvon sukvvon commented Sep 3, 2026

Copy link
Copy Markdown
Member

🎯 Changes

Fixes broken links for docs/framework/{react,solid}/reference/*.md URLs that returned a flat page before the TypeDoc migration (react: #11205/#11366, solid: #11368/#11369) moved them under functions/. Requests to the old flat URLs currently fall through to the framework docs index instead of resolving. Reported in #11371.

Adds redirect_from frontmatter (per tanstack.com's redirect convention) to the affected pages, split into two kinds:

  • Generated pages (functions/*.md, 19 react + 10 solid): scripts/generate-docs.ts now injects redirect_from into each package's TypeDoc output as a post-processing step, keyed off a per-package mapping. This runs on every pnpm run generate-docs, so the redirects survive regeneration without manual upkeep.
  • Hand-maintained pages (10 files): docs/reference/*.md (9 files — QueryClient, QueryCache, MutationCache, QueryObserver, QueriesObserver, InfiniteQueryObserver, focusManager, notifyManager, onlineManager) and docs/framework/react/guides/ssr.md. These pages aren't generated by the script (query-core is excluded from every framework's TypeDoc entry point, and hydration.md's content lives in the SSR guide), so their redirect_from was added directly and isn't part of the generation pipeline.

docs/framework/solid/reference/hydration.md is not redirected — its content was never anything but a react-guide clone (ref:/replace:) and docs/framework/solid/guides/ssr.md is currently a stub, so there's no real target to send readers to.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Documentation
    • Added redirects from legacy React and Solid reference URLs to their current documentation pages.
    • Added a redirect from the former hydration guide URL to the SSR guide.
    • Added redirects for legacy core reference pages, including query, mutation, cache, observer, and manager documentation.
    • Updated documentation generation to preserve redirects automatically for future reference pages.

@sukvvon
sukvvon requested a review from a team as a code owner September 3, 2026 06:57
@sukvvon sukvvon self-assigned this Sep 3, 2026
@nx-cloud

nx-cloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit a3fe250

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 16s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-03 07:02:10 UTC

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

2 package(s) bumped directly, 23 bumped as dependents.

🟨 Minor bumps

Package Version Reason
@tanstack/svelte-query 6.1.48 → 6.2.0 Changeset
@tanstack/svelte-query-devtools 6.1.48 → 6.2.0 Dependent
@tanstack/svelte-query-persist-client 6.1.48 → 6.2.0 Dependent
@tanstack/vue-query-devtools 6.1.48 → 6.2.0 Dependent

🟩 Patch bumps

Package Version Reason
@tanstack/query-core 5.102.8 → 5.102.9 Changeset
@tanstack/angular-query-experimental 5.102.8 → 5.102.9 Dependent
@tanstack/angular-query-persist-client 5.102.8 → 5.102.9 Dependent
@tanstack/eslint-plugin-query 5.102.8 → 5.102.9 Dependent
@tanstack/lit-query 0.2.20 → 0.2.21 Dependent
@tanstack/preact-query 5.102.8 → 5.102.9 Dependent
@tanstack/preact-query-devtools 5.102.8 → 5.102.9 Dependent
@tanstack/preact-query-persist-client 5.102.8 → 5.102.9 Dependent
@tanstack/query-async-storage-persister 5.102.8 → 5.102.9 Dependent
@tanstack/query-broadcast-client-experimental 5.102.8 → 5.102.9 Dependent
@tanstack/query-devtools 5.102.8 → 5.102.9 Dependent
@tanstack/query-persist-client-core 5.102.8 → 5.102.9 Dependent
@tanstack/query-sync-storage-persister 5.102.8 → 5.102.9 Dependent
@tanstack/react-query 5.102.8 → 5.102.9 Dependent
@tanstack/react-query-devtools 5.102.8 → 5.102.9 Dependent
@tanstack/react-query-next-experimental 5.102.8 → 5.102.9 Dependent
@tanstack/react-query-persist-client 5.102.8 → 5.102.9 Dependent
@tanstack/solid-query 5.102.8 → 5.102.9 Dependent
@tanstack/solid-query-devtools 5.102.8 → 5.102.9 Dependent
@tanstack/solid-query-persist-client 5.102.8 → 5.102.9 Dependent
@tanstack/vue-query 5.102.8 → 5.102.9 Dependent

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 85bc6a2d-28d4-4cbe-a4e4-e6fd94a348f2

📥 Commits

Reviewing files that changed from the base of the PR and between a0d8cfb and a3fe250.

📒 Files selected for processing (40)
  • docs/framework/react/guides/ssr.md
  • docs/framework/react/reference/functions/QueryClientProvider.md
  • docs/framework/react/reference/functions/QueryErrorResetBoundary.md
  • docs/framework/react/reference/functions/infiniteQueryOptions.md
  • docs/framework/react/reference/functions/mutationOptions.md
  • docs/framework/react/reference/functions/queryOptions.md
  • docs/framework/react/reference/functions/useInfiniteQuery.md
  • docs/framework/react/reference/functions/useIsFetching.md
  • docs/framework/react/reference/functions/useIsMutating.md
  • docs/framework/react/reference/functions/useMutation.md
  • docs/framework/react/reference/functions/useMutationState.md
  • docs/framework/react/reference/functions/usePrefetchInfiniteQuery.md
  • docs/framework/react/reference/functions/usePrefetchQuery.md
  • docs/framework/react/reference/functions/useQueries.md
  • docs/framework/react/reference/functions/useQuery.md
  • docs/framework/react/reference/functions/useQueryClient.md
  • docs/framework/react/reference/functions/useQueryErrorResetBoundary.md
  • docs/framework/react/reference/functions/useSuspenseInfiniteQuery.md
  • docs/framework/react/reference/functions/useSuspenseQueries.md
  • docs/framework/react/reference/functions/useSuspenseQuery.md
  • docs/framework/solid/reference/functions/infiniteQueryOptions.md
  • docs/framework/solid/reference/functions/mutationOptions.md
  • docs/framework/solid/reference/functions/queryOptions.md
  • docs/framework/solid/reference/functions/useInfiniteQuery.md
  • docs/framework/solid/reference/functions/useIsFetching.md
  • docs/framework/solid/reference/functions/useIsMutating.md
  • docs/framework/solid/reference/functions/useMutation.md
  • docs/framework/solid/reference/functions/useMutationState.md
  • docs/framework/solid/reference/functions/useQueries.md
  • docs/framework/solid/reference/functions/useQuery.md
  • docs/reference/InfiniteQueryObserver.md
  • docs/reference/MutationCache.md
  • docs/reference/QueriesObserver.md
  • docs/reference/QueryCache.md
  • docs/reference/QueryClient.md
  • docs/reference/QueryObserver.md
  • docs/reference/focusManager.md
  • docs/reference/notifyManager.md
  • docs/reference/onlineManager.md
  • scripts/generate-docs.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The documentation generator now applies configured redirect_from metadata to generated pages. React, Solid, and shared reference pages include redirects from legacy framework-specific URLs.

Changes

Documentation redirect metadata

Layer / File(s) Summary
Redirect generation and package configuration
scripts/generate-docs.ts
The generator accepts redirect mappings, writes redirect_from lists into page frontmatter, and defines mappings for React and Solid reference pages.
React page redirects
docs/framework/react/...
React guide and reference pages declare redirects from their previous paths.
Solid page redirects
docs/framework/solid/...
Solid reference pages declare redirects from their previous paths.
Shared reference redirects
docs/reference/*
Shared reference pages declare redirects from former React-specific paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a3fe2

This change adds static legacy documentation redirects and preserves them through regeneration. No current merge-readiness risk remains.

Suggested reviewers: alemtuzlak

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (39 skipped: 3… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: restoring redirects for flat reference URLs broken by the TypeDoc migration.
Description check ✅ Passed The description follows the required template, explains the motivation and implementation, documents the Solid hydration exception, and completes the checklist and release-impact sections.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (39 skipped: 39 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/redirect-flat-reference-urls

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 3, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11379

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11379

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11379

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11379

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11379

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11379

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11379

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11379

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11379

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11379

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11379

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11379

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11379

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11379

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11379

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11379

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11379

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11379

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11379

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11379

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11379

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11379

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11379

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11379

commit: a3fe250

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.87 KB (0%)
react minimal 8.84 KB (0%)

@sukvvon
sukvvon requested a review from TkDodo September 3, 2026 07:23
@sukvvon
sukvvon merged commit a29ca68 into main Sep 3, 2026
9 checks passed
@sukvvon
sukvvon deleted the docs/redirect-flat-reference-urls branch September 3, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants