Skip to content

chore(*): replace 'typescript-eslint' with '@typescript-eslint/parser' in preact packages and remove redundant eslint options #11791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 2 commits into from
Oct 1, 2026
+24 −91
Merged

chore(*): replace 'typescript-eslint' with '@typescript-eslint/parser' in preact packages and remove redundant eslint options #11791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b1bac4
chore(*): replace 'typescript-eslint' with '@typescript-eslint/parser…
sukvvon Oct 1, 2026
1922e96
style(*): add a blank line after '@ts-check' and remove the blank lin…
sukvvon Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions packages/preact-query-devtools/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,16 @@
// @ts-check

// @ts-ignore: no types for eslint-config-preact
import preact from 'eslint-config-preact'
// eslint-config-preact uses typescript-eslint under the hood
import tseslint from 'typescript-eslint'

import tsParser from '@typescript-eslint/parser'
import rootConfig from './root.eslint.config.js'

export default [
...rootConfig,
...preact,
{
files: ['**/*.{ts,tsx}'],
languageOptions: {
parser: tseslint.parser,
parserOptions: {
project: true,
},
},
plugins: {
'typescript-eslint': tseslint.plugin,
parser: tsParser,
},
rules: {
// Disable base rule to prevent overload false positives
Expand Down
4 changes: 2 additions & 2 deletions packages/preact-query-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@
"@preact/preset-vite": "catalog:",
"@tanstack/preact-query": "workspace:*",
"@testing-library/preact": "catalog:",
"@typescript-eslint/parser": "catalog:",
"eslint-config-preact": "catalog:",
"preact": "catalog:",
"typescript": "catalog:",
"typescript-eslint": "catalog:"
"typescript": "catalog:"
},
"peerDependencies": {
"@tanstack/preact-query": "workspace:^",
Expand Down
14 changes: 3 additions & 11 deletions packages/preact-query-persist-client/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,16 @@
// @ts-check

// @ts-ignore: no types for eslint-config-preact
import preact from 'eslint-config-preact'
// eslint-config-preact uses typescript-eslint under the hood
import tseslint from 'typescript-eslint'

import tsParser from '@typescript-eslint/parser'
import rootConfig from './root.eslint.config.js'

export default [
...rootConfig,
...preact,
{
files: ['**/*.{ts,tsx}'],
languageOptions: {
parser: tseslint.parser,
parserOptions: {
project: true,
},
},
plugins: {
'typescript-eslint': tseslint.plugin,
parser: tsParser,
},
rules: {
// Disable base rule to prevent overload false positives
Expand Down
4 changes: 2 additions & 2 deletions packages/preact-query-persist-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@
"@tanstack/preact-query": "workspace:*",
"@tanstack/query-test-utils": "workspace:*",
"@testing-library/preact": "catalog:",
"@typescript-eslint/parser": "catalog:",
"eslint-config-preact": "catalog:",
"preact": "catalog:",
"typescript": "catalog:",
"typescript-eslint": "catalog:"
"typescript": "catalog:"
},
"peerDependencies": {
"@tanstack/preact-query": "workspace:^",
Expand Down
14 changes: 3 additions & 11 deletions packages/preact-query/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,16 @@
// @ts-check

// @ts-ignore: no types for eslint-config-preact
import preact from 'eslint-config-preact'
// eslint-config-preact uses typescript-eslint under the hood
import tseslint from 'typescript-eslint'

import tsParser from '@typescript-eslint/parser'
import rootConfig from './root.eslint.config.js'

export default [
...rootConfig,
...preact,
{
files: ['**/*.{ts,tsx}'],
languageOptions: {
parser: tseslint.parser,
parserOptions: {
project: true,
},
},
plugins: {
'typescript-eslint': tseslint.plugin,
parser: tsParser,
},
rules: {
// Disable base rule to prevent overload false positives
Expand Down
4 changes: 2 additions & 2 deletions packages/preact-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@
"@tanstack/query-persist-client-core": "workspace:*",
"@tanstack/query-test-utils": "workspace:*",
"@testing-library/preact": "catalog:",
"@typescript-eslint/parser": "catalog:",
"eslint-config-preact": "catalog:",
"preact": "catalog:",
"preact-render-to-string": "^6.6.4",
"typescript": "catalog:",
"typescript-eslint": "catalog:"
"typescript": "catalog:"
},
"peerDependencies": {
"preact": "^10.0.0"
Expand Down
60 changes: 9 additions & 51 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ catalog:
typescript: 6.0.3
'@typescript-eslint/parser': ^8.70.1
eslint: ^9.36.0
typescript-eslint: ^8.70.1

# react
'@eslint-react/eslint-plugin': ^5.21.0
Expand Down
Loading