test(lit-query/createMutationController): add test for using mutation defaults by sukvvon · Pull Request #11793 · TanStack/query

sukvvon · 2026-10-01T03:42:05Z

🎯 Changes

Adds "should be able to use mutation defaults" to createMutationController tests. It registers a mutationFn with queryClient.setMutationDefaults for a mutationKey, creates the controller with only that mutationKey, and asserts the rendered output goes from idle to pending to success with the data from the default mutationFn.

No existing test checked that the controller applies the client's mutation defaults.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage confirming mutations use the configured default function when no local mutation function is provided, including the expected status and result.

… defaults

nx-cloud · 2026-10-01T03:42:29Z

View your CI Pipeline Execution ↗ for commit c367c05

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 30s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-01 03:46:50 UTC

github-actions · 2026-10-01T03:42:57Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-01T03:43:34Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5a5f3a2c-bc53-488e-b7ca-b6308765a54d

📥 Commits

Reviewing files that changed from the base of the PR and between 3df6cb9 and c367c05.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/createMutationController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Adds a test for a mutation controller that uses a mutation function configured with queryClient.setMutationDefaults when the controller has a mutationKey and no local mutationFn.

Changes

Mutation Defaults

Layer / File(s)	Summary
Verify default mutation execution `packages/lit-query/src/__tests__/createMutationController.test.ts`	The test checks the controller's idle and pending states, then verifies successful completion with the input text as data.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to c367c

This test-only change covers mutation defaults and successful results. It is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a test for mutation defaults in createMutationController.
Description check	✅ Passed	The description follows the required template. It explains the test change and motivation, completes the checklist, and identifies the change as dev-only with no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-01T03:44:37Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11793

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11793

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11793

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11793

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11793

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11793

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11793

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11793

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11793

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11793

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11793

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11793

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11793

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11793

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11793

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11793

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11793

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11793

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11793

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11793

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11793

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11793

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11793

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11793

commit: c367c05

github-actions · 2026-10-01T03:44:47Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/createMutationController): add test for using mutation…

c367c05

… defaults

sukvvon self-assigned this Oct 1, 2026

sukvvon merged commit ea21494 into main Oct 1, 2026
9 checks passed

sukvvon deleted the test/lit-query-create-mutation-controller-mutation-defaults branch October 1, 2026 05:13

Navigation Menu

Uh oh!

test(lit-query/createMutationController): add test for using mutation defaults - #11793

test(lit-query/createMutationController): add test for using mutation defaults#11793
sukvvon merged 1 commit into
mainfrom
test/lit-query-create-mutation-controller-mutation-defaults

sukvvon commented Oct 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Oct 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 1, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 1, 2026 •

edited

Loading

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading