optimize load-client.ts for bundlesize - #7998
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesClient loader state handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 78f53f3
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will degrade performance by 17.18%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server error-paths not-found (vue) |
318.6 KB | 2,130.5 KB | -85.04% |
| ❌ | Memory | mem client unique-location-churn (solid) |
341.6 KB | 588.7 KB | -41.97% |
| ❌ | Simulation | ssr dehydrate rich types (solid) |
87.3 ms | 99.8 ms | -12.49% |
| ❌ | Memory | mem client navigation-churn (solid) |
570.2 KB | 621 KB | -8.18% |
| ❌ | Simulation | ssr dehydrate plain control (solid) |
119.6 ms | 129.3 ms | -7.51% |
| ❌ | Simulation | ssr control-flow route headers (react) |
85 ms | 87.8 ms | -3.23% |
| ⚡ | Memory | mem server error-paths redirect (solid) |
588.2 KB | 277.9 KB | ×2.1 |
| ⚡ | Memory | mem client preload-churn (vue) |
776.2 KB | 735.9 KB | +5.47% |
| ⚡ | Simulation | ssr control-flow unmatched 404 (react) |
67.2 ms | 64.1 ms | +4.82% |
| ⚡ | Simulation | ssr request loop (solid) |
158 ms | 152 ms | +3.98% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bundlesize-load-client (78f53f3) with main (c568caf)
a28b3d3 to
5f744df
Compare
e5f94a7 to
b0c1139
Compare
5f744df to
8c88574
Compare
Summary by CodeRabbit