Skip to content

perf(router-core): optimize server search serialization - #8012

Draft
Sheraff wants to merge 1 commit into
mainfrom
codex/server-search-serialization
Draft

perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom
codex/server-search-serialization

Conversation

@Sheraff

@Sheraff Sheraff commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.

The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.

Why

#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.

Performance

Measured with the same Vitest benchmark file against the exact merged #8006 implementation:

  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster

Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.

The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.

Validation

  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 0ae9eb0

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 10m 23s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 14s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

2 package(s) bumped directly, 21 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/router-core 1.171.19 → 1.171.20 Changeset
@tanstack/start-client-core 1.170.19 → 1.170.20 Changeset
@tanstack/react-router 1.170.23 → 1.170.24 Dependent
@tanstack/react-start 1.168.40 → 1.168.41 Dependent
@tanstack/react-start-client 1.168.21 → 1.168.22 Dependent
@tanstack/react-start-rsc 0.1.39 → 0.1.40 Dependent
@tanstack/react-start-server 1.167.28 → 1.167.29 Dependent
@tanstack/router-cli 1.167.25 → 1.167.26 Dependent
@tanstack/router-generator 1.167.25 → 1.167.26 Dependent
@tanstack/router-plugin 1.168.27 → 1.168.28 Dependent
@tanstack/router-vite-plugin 1.167.27 → 1.167.28 Dependent
@tanstack/solid-router 1.170.22 → 1.170.23 Dependent
@tanstack/solid-start 1.168.39 → 1.168.40 Dependent
@tanstack/solid-start-client 1.168.21 → 1.168.22 Dependent
@tanstack/solid-start-server 1.167.28 → 1.167.29 Dependent
@tanstack/start-plugin-core 1.171.31 → 1.171.32 Dependent
@tanstack/start-server-core 1.169.23 → 1.169.24 Dependent
@tanstack/start-static-server-functions 1.167.24 → 1.167.25 Dependent
@tanstack/start-storage-context 1.167.21 → 1.167.22 Dependent
@tanstack/vue-router 1.170.21 → 1.170.22 Dependent
@tanstack/vue-start 1.168.38 → 1.168.39 Dependent
@tanstack/vue-start-client 1.167.24 → 1.167.25 Dependent
@tanstack/vue-start-server 1.167.28 → 1.167.29 Dependent

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

This pull request does not affect bundle size in any measured scenario.

@pkg-pr-new

pkg-pr-new Bot commented Aug 8, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0

@codspeed-hq

codspeed-hq Bot commented Aug 8, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.08%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory mem server error-paths redirect (vue) 433.1 KB 904.6 KB -52.13%
Memory mem server error-paths unmatched (solid) 428.5 KB 454.6 KB -5.75%
Memory mem server server-fn-churn (react) 264.7 KB 276.7 KB -4.31%
Memory mem server error-paths not-found (solid) 728.6 KB 418.6 KB +74.03%
Memory mem client preload-churn (vue) 805.5 KB 736.9 KB +9.32%
Memory mem client navigation-churn (solid) 575 KB 528.4 KB +8.83%
Simulation ssr dehydrate rich types (solid) 99.7 ms 95.9 ms +4.01%
Memory mem server error-paths unmatched (react) 272.3 KB 263.2 KB +3.48%
Memory mem client unique-location-churn (solid) 352.4 KB 341.5 KB +3.18%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant