Upgrade solidjs beta 32 - #8014
Conversation
- solid-js / @solidjs/web / babel-preset-solid: 2.0.0-beta.29 -> 2.0.0-beta.32 - vite-plugin-solid: ^3.0.0-next.21 -> ^3.0.0-next.23 (ships @dom-expressions/compiler 0.50.0-next.40) - Migrate server tests off removed renderToStringAsync: awaiting renderToStream() now resolves with the fully-settled HTML string Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 161f885
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview6 package(s) bumped directly, 0 bumped as dependents. 🟩 Patch bumps
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will improve performance by 59.64%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | ssr request loop (react) |
330.5 ms | 79.4 ms | ×4.2 |
| ⚡ | Simulation | client-side navigation loop (solid) |
72.6 ms | 43.9 ms | +65.39% |
| ⚡ | Simulation | ssr request loop (vue) |
420.3 ms | 269.5 ms | +55.93% |
| ⚡ | Simulation | client-side navigation loop (react) |
56.3 ms | 47.5 ms | +18.53% |
| ⚡ | Simulation | client-side navigation loop (vue) |
83 ms | 72.7 ms | +14.16% |
| ⚡ | Simulation | ssr request loop (solid) |
174.6 ms | 153.2 ms | +13.97% |
| 🆕 | Simulation | ssr not-found (vue) |
N/A | 145.4 ms | N/A |
| 🆕 | Simulation | ssr redirect (vue) |
N/A | 49.8 ms | N/A |
| 🆕 | Simulation | ssr head (vue) |
N/A | 293.1 ms | N/A |
| 🆕 | Simulation | ssr loaders (vue) |
N/A | 117.1 ms | N/A |
| 🆕 | Simulation | ssr selective (vue) |
N/A | 126.3 ms | N/A |
| 🆕 | Simulation | ssr server-fn GET (vue) |
N/A | 77.7 ms | N/A |
| 🆕 | Simulation | ssr server-fn POST (vue) |
N/A | 75.5 ms | N/A |
| 🆕 | Simulation | ssr server-route middleware (vue) |
N/A | 56.1 ms | N/A |
| 🆕 | Simulation | ssr server-route (vue) |
N/A | 55.9 ms | N/A |
| 🆕 | Simulation | ssr streaming deferred (vue) |
N/A | 94.7 ms | N/A |
| 🆕 | Simulation | ssr assets inline-css cdn (vue) |
N/A | 161.4 ms | N/A |
| 🆕 | Simulation | ssr assets linked-css control (vue) |
N/A | 191.7 ms | N/A |
| 🆕 | Simulation | ssr before-load chain (vue) |
N/A | 153.4 ms | N/A |
| 🆕 | Simulation | ssr control-flow error 500 (vue) |
N/A | 174 ms | N/A |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing upgrade-solidjs-beta-32 (bcc3587) with solid-router-v2-pre (67a9040)1
Upgrades to the latest Solid 2.0 beta (skips over beta.30/31) and the latest plugin.
solid-js,@solidjs/web,babel-preset-solid→2.0.0-beta.32vite-plugin-solid→3.0.0-next.23(peer-requires>=2.0.0-beta.32, ships@dom-expressions/compiler@0.50.0-next.40)Breaking change handled:
renderToStringAsyncremovedbeta.32's
@solidjs/webexports onlyrender,renderToString(now synchronous-only), andrenderToStream. The replacement for the old async-settled string render is built into the stream object:await renderToStream(...)resolves with the complete HTML once every boundary settles. The two server test files inpackages/solid-routerwere migrated accordingly; no runtime source used the removed API.Verification
packages/solid-routertest:unit(client)packages/solid-routertest:unit(server)e2e/solid-start/basicbuild + e2eCounts match the beta.29 baseline (client suite grew 814 → 838 from tests added on the base branch since). Lockfile audited: zero stale beta.29/next.21 resolutions, transitive
babel-preset-solidmoved to beta.32 on a plain install (no lockfile surgery needed).🤖 Generated with Claude Code