You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(hotkeys): make the cheat sheet dismissible after pointer interaction - #1401
The Hotkeys cheat sheet could stay open after a visitor clicked inside it, because focus left the element handling Escape. Its overlay also covered the toggle without providing a pointer dismissal control.
Add a visible Close button and listen for Escape while the sheet is open regardless of focus location. Follow-up to #1400.
AI review notes:
Validation: pnpm test passed. In a local browser fixture using the changed demo component, its real Hotkeys dependency, extracted unchanged LandingWindow wrapper and site CSS, opening the sheet, clicking inside, then pressing Escape dismissed it. Clicking Close also dismissed it. The rendered control was visually inspected. This is component-level browser coverage, not a full-site or physical touch-device test.
Summary by CodeRabbit
Bug Fixes
Updated the cheat sheet’s close shortcut to work with the default keyboard target.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
The cheat sheet’s Escape hotkey no longer targets cardRef. A Close button replaces the “Esc to close” hint and closes the cheat sheet when clicked.
Changes: Cheat Sheet Close Controls
Layer / File(s)
Summary
Configure and expose close controls src/components/landing/HotkeysLandingDemos.client.tsx
The Escape hotkey no longer targets cardRef and remains enabled while the cheat sheet is open. A Close button calls setSheetOpen(false).
Visitors can dismiss the cheat sheet with Close or Escape after interacting with it; no concrete product or operational risk remains from this change.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the primary change: making the Hotkeys cheat sheet dismissible after pointer interaction.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hotkeys cheat sheet could stay open after a visitor clicked inside it, because focus left the element handling Escape. Its overlay also covered the toggle without providing a pointer dismissal control.
Add a visible Close button and listen for Escape while the sheet is open regardless of focus location. Follow-up to #1400.
Summary by CodeRabbit