Skip to content

fix(hotkeys): make the cheat sheet dismissible after pointer interaction - #1401

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/hotkeys-cheat-sheet-dismissal
Oct 19, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/hotkeys-cheat-sheet-dismissal

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

The Hotkeys cheat sheet could stay open after a visitor clicked inside it, because focus left the element handling Escape. Its overlay also covered the toggle without providing a pointer dismissal control.

Add a visible Close button and listen for Escape while the sheet is open regardless of focus location. Follow-up to #1400.

AI review notes:
Validation: pnpm test passed. In a local browser fixture using the changed demo component, its real Hotkeys dependency, extracted unchanged LandingWindow wrapper and site CSS, opening the sheet, clicking inside, then pressing Escape dismissed it. Clicking Close also dismissed it. The rendered control was visually inspected. This is component-level browser coverage, not a full-site or physical touch-device test.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the cheat sheet’s close shortcut to work with the default keyboard target.
  • New Features
    • Added a Close button to dismiss the cheat sheet.

@changeset-bot

changeset-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 956e8b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ac882ac9-d4e1-43f9-8417-e9c1914028c9
📥 Commits

Reviewing files that changed from the base of the PR and between de24473 and 956e8b0.

📒 Files selected for processing: 1
  • src/components/landing/HotkeysLandingDemos.client.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The cheat sheet’s Escape hotkey no longer targets cardRef. A Close button replaces the “Esc to close” hint and closes the cheat sheet when clicked.

Changes: Cheat Sheet Close Controls

Layer / File(s) Summary
Configure and expose close controls
src/components/landing/HotkeysLandingDemos.client.tsx
The Escape hotkey no longer targets cardRef and remains enabled while the cheat sheet is open. A Close button calls setSheetOpen(false).

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: kevinvandy

Merge Risk: ⚪ Minimal · up to 956e8

Visitors can dismiss the cheat sheet with Close or Escape after interacting with it; no concrete product or operational risk remains from this change.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the primary change: making the Hotkeys cheat sheet dismissible after pointer interaction.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley
tannerlinsley merged commit bce7f7e into main Oct 19, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the taren/hotkeys-cheat-sheet-dismissal branch October 19, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant