Skip to content

Preserve the spinner section anchor - #1404

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/spinner-section-anchor
Oct 20, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/spinner-section-anchor

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

The spinner page’s “Sizes & color” sidebar link still targets #sizes-and-color, but #1121 changed the section heading to Spinner and therefore changed its generated anchor. Allow an explicit section ID and preserve the existing anchor on this section.

AI review notes:
Found the mismatch in the deployed full site. Verified the actual updated section in an isolated rendered fixture: #sizes-and-color targets Spinner, and Headbanger keeps its existing anchor. Full pnpm test passed before commit; the normal commit hook also runs the repository checks. Full production sidebar verification follows deployment.

Summary by CodeRabbit

  • New Features
    • Design system sections can now use custom identifiers for direct linking.
    • Added a direct-link identifier for the Spinner sizes and color section.

@changeset-bot

changeset-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 531b4fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ec502a7a-dffc-496b-a7cb-8cd1f1e8abb3
📥 Commits

Reviewing files that changed from the base of the PR and between 2ede98d and 531b4fd.

📒 Files selected for processing: 2
  • src/components/ds/DsKit.tsx
  • src/routes/ds.spinner.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📝 Walkthrough

DsSection now accepts an optional explicit ID. The Spinner design-system section uses sizes-and-color as its ID.

Changes: Design-system section IDs

Layer / File(s) Summary
Add optional section IDs
src/components/ds/DsKit.tsx, src/routes/ds.spinner.tsx
DsSection uses the supplied ID when present and otherwise derives one from the title. The Spinner section sets its ID to sizes-and-color.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: abeuty

Merge Risk: ⚪ Minimal · up to 531b4

The anchor-preservation change is ready to merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preserving the Spinner section anchor.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley
tannerlinsley merged commit d3ddc63 into main Oct 20, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the taren/spinner-section-anchor branch October 20, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant