fix: local okta sso flow#59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Adds automatic
.envfile loading on server startup and makes the Oktasso token cookie name configurable via an environment variable.What changed?
loadEnv.tsmodule that attempts to load a.envfile from the project root usingprocess.loadEnvFile. If no.envfile is present, it silently continues, allowing environment variables to be sourced from the real environment instead.index.tsso it runs before anything else.AUTH_JWT_TOKEN_COOKIE_NAMEinstead of using the hardcoded stringOKTASSO_TOKEN.How to test?
.envfile at the project root with relevant environment variables and start the server — confirm the variables are picked up correctly..envfile — confirm it starts without errors.AUTH_JWT_TOKEN_COOKIE_NAME.Why make this change?
Hardcoding the
.envloading approach and the cookie name reduced flexibility across environments. Loading the.envfile automatically removes the need for manual setup steps, and making the cookie name configurable allows it to stay in sync with the JWT token cookie name used elsewhere in the application.