Skip to content

feat: Guided Tours Cleanup#2417

Open
camielvs wants to merge 1 commit into
06-12-feat_guided_tours_e2e_testsfrom
06-15-feat_guided_tours_cleanup
Open

feat: Guided Tours Cleanup#2417
camielvs wants to merge 1 commit into
06-12-feat_guided_tours_e2e_testsfrom
06-15-feat_guided_tours_cleanup

Conversation

@camielvs

@camielvs camielvs commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

CLeans up complex functions and does some refactoring to make things a bit more manageable.

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/644

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Additional Comments

@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 06-15-feat_guided_tours_cleanup/a4cbf76

This was referenced Jun 15, 2026
Open
Open
Open
Open
Open
Open
Open
Open
@camielvs Graphite App

camielvs commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs mentioned this pull request Jun 15, 2026
Open
3 tasks
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch 2 times, most recently from e3505bc to 1674b0f Compare June 15, 2026 18:47
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch 2 times, most recently from 088f063 to ef6a2d0 Compare June 15, 2026 18:59
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 1674b0f to bc08155 Compare June 15, 2026 18:59
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from ef6a2d0 to b583f84 Compare June 15, 2026 19:21
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from bc08155 to 3559d73 Compare June 15, 2026 19:21
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from b583f84 to cf0a129 Compare June 15, 2026 19:32
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch 2 times, most recently from 7cff3f0 to 9465f4f Compare June 15, 2026 19:49
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from cf0a129 to 03beccf Compare June 15, 2026 19:49
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 9465f4f to e099377 Compare June 15, 2026 20:13
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from 03beccf to d725087 Compare June 15, 2026 20:13
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from e099377 to e8777f3 Compare June 15, 2026 22:34
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from d725087 to 94310c5 Compare June 15, 2026 22:34
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from e8777f3 to d9f058b Compare June 15, 2026 22:36
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from 94310c5 to 515a226 Compare June 15, 2026 22:36
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from d9f058b to 84e7368 Compare June 15, 2026 22:55
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from 515a226 to e2d29d7 Compare June 15, 2026 22:55
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch 2 times, most recently from 7618521 to aeba38f Compare June 19, 2026 21:48
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch 2 times, most recently from 84979cf to a795168 Compare June 26, 2026 00:20
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from aeba38f to 2b646c2 Compare June 26, 2026 00:20
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from a795168 to 02bc46f Compare June 26, 2026 00:37
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 2b646c2 to 49b4606 Compare June 26, 2026 00:37
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from 02bc46f to d723728 Compare June 26, 2026 00:53
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 49b4606 to 78e5321 Compare June 26, 2026 00:53
maxy-shpfy
maxy-shpfy reviewed Jun 26, 2026
View reviewed changes
Comment thread src/routes/v2/pages/Editor/components/editorTourBridge.utils.ts Outdated
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 78e5321 to e5eca2a Compare June 26, 2026 17:20
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from d723728 to b559fab Compare June 26, 2026 17:20
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from e5eca2a to da86de0 Compare June 26, 2026 17:22
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from b559fab to 1ca1506 Compare June 26, 2026 19:28
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch 2 times, most recently from 170f624 to d555675 Compare June 26, 2026 19:49
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from 1ca1506 to 932e04d Compare June 26, 2026 19:49
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from d555675 to f10c815 Compare June 26, 2026 20:52
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from 6849d2e to 9758cf2 Compare June 26, 2026 21:10
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from f10c815 to 1148eac Compare June 26, 2026 21:10
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from 9758cf2 to a8350a7 Compare June 26, 2026 21:13
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch 2 times, most recently from 72139cd to 657a591 Compare June 26, 2026 21:28
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from a8350a7 to 32680c5 Compare June 26, 2026 21:28
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 657a591 to e620878 Compare June 26, 2026 21:29
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch 2 times, most recently from 63d62b1 to fb96194 Compare June 26, 2026 21:30
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from e620878 to f7f0fff Compare June 26, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxy-shpfy maxy-shpfy maxy-shpfy approved these changes

Assignees

No one assigned

Labels

#gsd:50583 Learning Hub

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camielvs @maxy-shpfy