Skip to content

fix: disable upgraded components lookup in search results#2463

Merged
maxy-shpfy merged 1 commit into
masterfrom
06-28-fix_disable_upgraded_components_lookup_in_search_results
Jun 29, 2026
Merged

fix: disable upgraded components lookup in search results#2463
maxy-shpfy merged 1 commit into
masterfrom
06-28-fix_disable_upgraded_components_lookup_in_search_results

Conversation

@maxy-shpfy

@maxy-shpfy maxy-shpfy commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Contributes to https://github.com/Shopify/oasis-frontend/issues/670

The outdated badge in ComponentItem is now hidden when rendering results in the ComponentSearchResults view. A new showOutdatedBadge prop has been added to ComponentMarkup, which defaults to true but is passed as false from ComponentSearchResults. The badge visibility also continues to respect the remote-component-library-search feature flag.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Enable the remote-component-library-search feature flag.
  2. Open the component search panel and perform a search.
  3. Verify that the outdated badge does not appear on results rendered in the ComponentSearchResults view.
  4. Verify that the outdated badge still appears as expected in other contexts where showOutdatedBadge is not explicitly set to false.

Additional Comments

The default value of showOutdatedBadge is true, so existing usages of ComponentMarkup are unaffected unless explicitly opted out.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 06-28-fix_disable_upgraded_components_lookup_in_search_results/cc8a5bd

maxy-shpfy commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy marked this pull request as ready for review June 29, 2026 04:39
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner June 29, 2026 04:39

maxy-shpfy commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jun 29, 6:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 29, 6:10 PM UTC: Graphite couldn't merge this PR because it had merge conflicts.
  • Jun 29, 6:27 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 29, 6:27 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy force-pushed the 06-28-fix_disable_upgraded_components_lookup_in_search_results branch from 2d6cb5a to cc8a5bd Compare June 29, 2026 18:17
@maxy-shpfy maxy-shpfy merged commit f0e58ed into master Jun 29, 2026
23 checks passed
@maxy-shpfy maxy-shpfy deleted the 06-28-fix_disable_upgraded_components_lookup_in_search_results branch June 29, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants