Add editor v2 welcome spotlight and default path routing#2473
Open
Mbeaulne wants to merge 1 commit into
Open
Conversation
🎩 PreviewA preview build has been created at: |
8fc9699 to
a79b994
Compare
a79b994 to
65b2b39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Introduces a
getDefaultEditorPathhelper in a newsrc/routes/editorRoutes.tsmodule that resolves the correct editor path based on whether thev2_editorfeature flag is enabled. When the flag is on, navigation targets/editor-v2/<pipelineName>; otherwise it falls back to/editor/<pipelineName>. All hardcoded editor path constructions across the codebase have been replaced with this helper.Additionally, the
editorV2RouteandeditorV2PipelineRouteroutes now include abeforeLoadguard that redirects users to the legacy editor (or pipelines dashboard) if thev2_editorflag is disabled, preventing direct access to the v2 editor without the flag.A first-time welcome spotlight (
EditorV2WelcomeSpotlight) has been added. When a user lands on the v2 editor for the first time, a spotlight overlay highlights the editor version toggle button with a brief explanatory card. Dismissal is persisted to local storage so the spotlight is only shown once.The
component_searchfeature flag default has been changed fromfalsetotrue, enabling the experimental component search by default.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
v2_editorfeature flag and verify that all navigation entry points (pipeline row clicks, new pipeline button, import, run toolbar, favorites, recently viewed) route to/editor-v2/<name>.v2_editorflag and confirm all the same entry points route to/editor/<name>and that direct navigation to/editor-v2/<name>redirects appropriately.v2_editorflag enabled, open the v2 editor for the first time and confirm the welcome spotlight appears over the version toggle button, can be dismissed via the "Got it" button, Escape key, or clicking outside, and does not reappear after dismissal.Additional Comments
The
getDefaultEditorPathutility centralises all editor URL construction, making future editor version routing changes a single-file update.