Bugfix 3726 - #53
Merged
Merged
Conversation
## Dev Board Ticket - https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3726 ## Changes - Fixed OSW→OSM ID remapping so ways preserve references to the exact `ogr2osm` node objects instead of resolving by duplicate temporary numeric IDs. - Prevented generated point-node IDs from being overwritten by OSW `_id` values, avoiding temporary node ID collisions before output. - Added BUG-3726 regression fixtures with real San Diego coordinates. - Added regression coverage to verify converted OSM ways keep local geometry and do not create cross-map spider lines. - Bumped package version to `0.3.6` and updated the changelog. ## Testing - `python -m unittest tests.unit_tests.test_osw2osm.test_osw2osm` - `python -m unittest discover tests/unit_tests`
- Unit Tests workflow - Coverage badge from the repo badges branch
shweta2101
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Board Ticket
Changes
ogr2osmnode objects instead of resolving by duplicate temporary numeric IDs._idvalues, avoiding temporary node ID collisions before output.0.3.6and updated the changelog.Testing
python -m unittest tests.unit_tests.test_osw2osm.test_osw2osmpython -m unittest discover tests/unit_tests