[0.3.7] Fix zero-length geometry and preserve non-compliant tags as extensions - #55
Merged
Conversation
…xtensions ## DevBoard - https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/4066 ## Changes - Added shared geometry cleanup helpers for LineString, Polygon, MultiLineString, and MultiPolygon geometries. - Removes duplicate consecutive coordinates from line and polygon geometries. - Prevents zero-length LineString geometries from being emitted as OSW edges or lines. - Prevents collapsed or zero-area Polygon geometries from being emitted as OSW polygons or zones. - OSM edge segments with identical endpoint coordinates are no longer emitted as OSW edges, even when node IDs differ. - Collapsed OSM edge/way features are preserved as valid custom OSW points when a coordinate is available. - Fallback custom OSW points preserve original way tags as `ext:*`. - Prevents invalid OSW node output containing edge properties like `highway`, `footway`, or `surface`. - OSW→OSM collapsed edges, lines, polygons, and zones are converted to OSM node/Point fallbacks instead of being silently dropped. - OSW→OSM duplicate consecutive coordinates are cleaned before conversion. - OSM→OSW unknown, unsupported, or non-OSW-compliant tags are preserved as `ext:*`. - Invalid values for known OSW fields are preserved as `ext:*` instead of being dropped. - Existing `ext:*` tags remain unchanged. - Added real-format OSM XML fixtures for zero-length OSM scenarios. - Added zipped OSW datasets for zero-length OSW scenarios. - Added consolidated zero-length geometry unit coverage. - Updated OSW normalizer tests for `ext:*` preservation behavior. ## Validation ```text 288 tests passed ```
susrisha
approved these changes
Jul 23, 2026
MashB
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevBoard
Changes
ext:*.highway,footway, orsurface.ext:*.ext:*instead of being dropped.ext:*tags remain unchanged.ext:*preservation behavior.Validation