Repository navigation
⚡ Bolt: Pre-calculate capacity and avoid write! formatting in fstring_concat - #362
Tcode-Motion wants to merge 2 commits into
Conversation
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
💡 What: Optimized
fstring_concatintechscript_builtinsby pre-allocatingStringcapacity based on argument types and appendingValue::Strusingpush_strinstead of going throughwrite!formatting macro.🎯 Why: Previously,
fstring_concatstarted with an unallocatedString::new()and repeatedly formatted arguments usingwrite!(res, "{}", arg), causing multiple buffer allocations/reallocations and formatting overhead for strings.📊 Impact: Reduces string allocations and formatting overhead during f-string evaluations in TechScript programs.
🔬 Measurement: Measured with
bench_fstring_concatinbuiltins_tests.rsacross 100,000 f-string concatenation operations (reduced execution time from ~199.19ms to ~162.84ms, an ~18% improvement in debug build testing).PR created automatically by Jules for task 10688590165131012732 started by @Tcode-Motion