Skip to content

PATCH /api/integrations/:id merges arbitrary config keys — needs an allowlist #1292

Description

@lilyshen0722

From sprint-review's #1290 pass: { ...currentConfig, ...config } (routes/integrations.ts) accepts any config key from any caller who passes canDeleteIntegration — including botToken, secretToken, accessToken, globalAgentAccess, agentAccessEnabled. Pre-existing on main; #1290 added a targeted guard for linkedUserId only (the live-relay attribution identity). The general fix is a per-type allowlist of client-settable keys, with credential-class and privilege-class keys excluded by default.

🤖 Generated with Claude Code

https://claude.ai/code/session_013pc6nGXRS8mHvrwcXMSRDK

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions