Skip to content

feat: localize builtin catalog descriptions - #1719

Open
lilyshen0722 wants to merge 6 commits into
mainfrom
kai/task038
Open

lilyshen0722 wants to merge 6 commits into
mainfrom
kai/task038

Conversation

@lilyshen0722

@lilyshen0722 lilyshen0722 commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add first-party locale descriptions to builtin connector/tool catalog metadata and Installable rows
  • return complete per-locale maps while keeping canonical description as the English fallback
  • keep marketplace rows unmodified and project them as { en }; the API no longer negotiates Accept-Language
  • use the app's i18n.resolvedLanguage ?? i18n.language via one shared frontend helper on both Connectors and Tools pages
  • collapse Slack's canonical English source into the manifest and seed locale maps for Telegram, Slack, Discord, GroupMe, and GitHub
  • include backend projection/source-isolation tests, frontend page/helper language coverage, and a current 1200×1000 zh-CN Connectors + Tools capture

Verification

  • backend: 68 targeted catalog/route/manifest/tool/seed/installable tests passed
  • backend: npm run build passed
  • frontend: 109 suites, 878 tests passed
  • frontend: npm run typecheck and npm run build passed; targeted lint has no errors (repository-wide lint has pre-existing unrelated errors)

Rebased onto main at 41874c46. Held for Wren/Vera review and Sam's native-speaker pass, per TASK-038 gates.

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Cross-reference, not a review: this PR is the home for the last item of TASK-179 (follow-ups carried out of #1981, the Connectors/Tools i18n migration).

That item is the server-English builtin catalogue description — the text entry.description renders at V2ConnectorTools.tsx:572 (not-yet row) and :671 (draft aside), which arrives from the API and so cannot be reached by either locale catalog. lily-shen's instruction for it was to route this PR rather than rebuild it, and #1982 carries no server-side change because of that.

Two things a reviewer will want to know, measured today rather than assumed:

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Second cross-reference, and this one is a warning rather than a status note: two of the six conflicts must not be resolved to 'theirs', or this PR silently reverts copy that was ruled after it was written.

Measured today against main 827b47e4 (this branch is 244 commits behind, merge-base 4e8de868):

The remaining conflicts are mechanical: frontend/src/v2/components/V2ConnectorTools.tsx, V2ConnectorsPage.tsx and V2ConnectorsPage.test.tsx conflict only on adjacent lines (imports, a 2-line sibling, an appended it() block), and this PR's localizeInstallableDescription.ts + test are new files that merge clean.

The mechanism here is what's wanted; the English (and therefore the Chinese beside it) in those two backend files is stale. Also noted on the pod board, TASK-179.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant