Skip to content

Stop generating invalid buffer loot table #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TeamDman wants to merge 1 commit into
base: 1.19.2
Choose a base branch
from
+3 −22
Draft

Stop generating invalid buffer loot table #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions platform/minecraft/src/datagen/java/ca/teamdman/sfm/datagen/SFMLootTablesDatagen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ protected void populate(BlockLootWriter writer) {
writer.dropSelf(SFMBlocks.MANAGER);
writer.dropSelf(SFMBlocks.TUNNELLED_MANAGER);
writer.dropSelf(SFMBlocks.CABLE);
writer.dropSelf(SFMBlocks.BUFFER_BLOCK);
writer.dropOther(SFMBlocks.CABLE_FACADE, SFMBlocks.CABLE);

// Tough cables
Expand All @@ -46,7 +45,9 @@ protected void populate(BlockLootWriter writer) {
protected Set<? extends SFMRegistryObject<Block, ? extends Block>> getExpectedBlocks() {
Set<SFMRegistryObject<Block, ? extends Block>> exclude = Set.of(
SFMBlocks.TEST_BARREL,
SFMBlocks.TEST_BARREL_TANK
SFMBlocks.TEST_BARREL_TANK,
// The buffer block is WIP and has no item outside the IDE.
SFMBlocks.BUFFER_BLOCK
);
HashSet<SFMRegistryObject<Block, ? extends Block>> ourBlocks = new HashSet<>(SFMBlocks.REGISTERER.getOurEntries());
ourBlocks.removeIf(exclude::contains);
Expand Down
20 changes: 0 additions & 20 deletions platform/minecraft/src/generated/resources/data/sfm/loot_tables/blocks/buffer.json
View file
Open in desktop

This file was deleted.