Feature: Place a task in a workflow stage on create or update - #141
Merged
Conversation
The v3 task request body carries a "workflows" object beside "task", taking workflowId, stageId and positionAfterTask, but nothing modelled it: only the response side existed, and TaskWorkflowStage's comment claimed a request role it never had. TaskWorkflows fills that in on TaskCreateRequest and TaskUpdateRequest, with IsZero so an unrelated request sends no such key. Its doc records what the two endpoints do and do not say: on create the task joins every workflow attached to its project in the backlog, and a workflow that is not one of the project's own is ignored with a 201; on update the task must already be in the named workflow or the answer is 404. Neither asks for permission to edit the workflow, unlike the routes behind WorkflowStageTaskMove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v3 task request body carries a "workflows" object alongside "task", taking
workflowId,stageIdandpositionAfterTask, but nothing modelled it: only the response side existed, andTaskWorkflowStage's comment claimed a request role it never had.TaskWorkflowsfills that in onTaskCreateRequestandTaskUpdateRequest, withIsZeroso an unrelated request sends no such key. Its doc records what the two endpoints do and do not say: on create, the task joins every workflow attached to its project in the backlog, and a workflow that is not one of the project's own is ignored with a 201; on update, the task must already be in the named workflow, or the answer is 404. Neither asks for permission to edit the workflow, unlike the routes behindWorkflowStageTaskMove.Type of Change
Testing
go test -v ./...)Checklist