Code Review - #10
Open
Tripl321 wants to merge 22 commits into
Open
Conversation
Removed emoji placeholders from the document.
Updated the security requirements table by removing redundant column title and improving clarity.
…omponents/SingleMessage.jsx för att uppfylla krav K1, K4 och K6. Se kommentarerna i koden för detaljer om varje ändring.
Added a security policy document outlining supported versions and vulnerability reporting.
Bumps [jsonwebtoken](https://github.com/auth0/node-jsonwebtoken) from 8.5.1 to 9.0.0. - [Changelog](https://github.com/auth0/node-jsonwebtoken/blob/master/CHANGELOG.md) - [Commits](auth0/node-jsonwebtoken@v8.5.1...v9.0.0) --- updated-dependencies: - dependency-name: jsonwebtoken dependency-version: 9.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Removes [esbuild](https://github.com/evanw/esbuild). It's no longer used after updating ancestor dependency [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). These dependencies need to be updated together. Removes `esbuild` Updates `vite` from 4.5.14 to 8.0.16 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.0.16/packages/vite) --- updated-dependencies: - dependency-name: esbuild dependency-version: dependency-type: indirect - dependency-name: vite dependency-version: 8.0.16 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [qs](https://github.com/ljharb/qs) from 6.15.1 to 6.15.2. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.15.1...v6.15.2) --- updated-dependencies: - dependency-name: qs dependency-version: 6.15.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
✅ Deploy Preview for yh-message-app-fullstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for yh-message-app-fullstack failed. Why did it fail? →
|
karinisaksson
left a comment
karinisaksson
left a comment
There was a problem hiding this comment.
Snyggt jobbat! Bara en grej jag tänkte på. Gällande K3: granskningslogg så fattar jag det som att loggarna inte sparas permanent om man kör console.log. Om loggarna ska sparas över tid och granskas i efterhand bör man skriva loggarna till fil eller databas. Men för detta projekt kanske console.log räcker.
…s-6.15.2 Bump qs from 6.15.1 to 6.15.2 in /backend
…multi-f57e1e291f Bump esbuild and vite in /frontend
…sonwebtoken-9.0.0 Bump jsonwebtoken from 8.5.1 to 9.0.0 in /backend
Updated tar module version to a more secure version.
Contributor
|
Ser ut som att ni missat att lägga upp något för granskningsfasen? Pinga mej när ni gjort det är ni snälla! 😊 |
Added detailed analysis of security alerts from Dependabot, focusing on jsonwebtoken vulnerabilities and proposed solutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.