Skip to content

fix(extension): harden websocket reconnect lifecycle - #82

Merged
BB-fat merged 1 commit into
mainfrom
takeover/pr19-websocket-reconnect
Aug 12, 2026
Merged

fix(extension): harden websocket reconnect lifecycle#82
BB-fat merged 1 commit into
mainfrom
takeover/pr19-websocket-reconnect

Conversation

@BB-fat

@BB-fat BB-fat commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Supersedes #19 — rebased onto current main and conflicts resolved. All credit to @NianJiuZst.

Conflict resolution notes

Rebased onto main after #17 landed; the two redundant commits (Biome formatting, port test fix) were dropped automatically since their content already reached main via #17. The remaining conflict in apps/extension/src/lib/connection-controller.ts was resolved by composing both changes instead of picking a side:

Verification

  • pnpm lint (biome check + stylelint): clean
  • tsc --noEmit: clean
  • vitest run: 571 passed / 48 failed — all 48 are the pre-existing React.act is not a function failures in .tsx popup/overlay tests; identical failure set on origin/main (48 there as well), so no regression. The 4 new tests from this PR pass.

@BB-fat
BB-fat merged commit f98c060 into main Aug 12, 2026
4 checks passed
@BB-fat
BB-fat deleted the takeover/pr19-websocket-reconnect branch August 12, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants