fix: fix kTaskLoopPolicy type in grouped gemm host code - #85
Open
icyhearts wants to merge 1 commit into
Open
Conversation
Author
|
@reed-lau hello, would you please take some time to review this PR? The modifications are simple. |
Collaborator
|
@weishengying could you please help review it? |
icyhearts
force-pushed
the
fix_kTaskLoopPolicy_type
branch
from
August 28, 2026 14:56
425332b to
4951620
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
group_gemm_blockwise_fp8_kernelandgroup_gemm_fp8_kernelexpect anint kTaskLoopPolicytemplate parameter, but their host-side callers pass abool kTaskLoopPolicy.The kernel expects
kTaskLoopPolicyto take the value0,1, or2, while aboolcan only representtrueorfalse. Therefore, usingboolhere is incorrect and may silently convert to0or1, making the2policy unreachable.This PR fixes the type mismatch by using
intforkTaskLoopPolicyin the host-side caller code.