refactor(topk): simplify the public API - #99
Open
VAthree wants to merge 1 commit into
Open
Conversation
Expose the operator as hpc.topk and align the public workspace query helpers with the same concise name. Keep the internal torch schemas and CUDA implementation unchanged. Rename the focused test module and update callers to the new API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the exact row-wise Top-K operator as
hpc.topkand align itsworkspace query helpers with the same concise name:
hpc.topk_workspace_sizehpc.topk_min_workspace_sizehpc.topk_peak_workspace_sizeRename the focused test module to
tests/test_topk.pyand update itscall sites to use the new API.
The native operator schemas and CUDA implementation remain unchanged;
this PR only simplifies the public Python interface.