feat(hooks): bridge TeamAI hooks into DeepSeek Harness - #689
Merged
Merged
Conversation
|
Findings
The PR description includes both a test plan and a real-CLI verification record, so no testing-description finding is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #623
What
@deepseek-ai/dsh-hooks-claude-codeCordis patch under~/.teamai/dsh/.--patchopt-in command, and clean the generated patch/config entries fromteamai hooks removeand targeted uninstall.~/.dsh/is not installed.Why
DeepSeek Harness already ships the Claude hook bridge, but
teamai init --agent dshpreviously synced skills while silently skipping hooks and still reported that resources would auto-sync on session start. This change makes the supported integration explicit and preserves unrelated hook entries.Validation
npm run typecheck— passed.npm run build— passed.npx vitest run src/__tests__/dsh-hooks.test.ts src/__tests__/omp-hooks.test.ts src/__tests__/opencode-hooks.test.ts— 49 passed.git diff --check— passed.teamai init . --agent dsh --forcegenerated and parsed the Claude hook JSON and Cordis patch;teamai hooks removeremoved the patch; a second init followed byteamai uninstall --agent dsh --forceremoved the patch again.npm testrun reached 230/265 files and 3,516/3,620 tests; the 101 failures and 20 errors are existing Windows-environment assumptions involving POSIX path assertions, file modes, symlinks, and Git subprocess/socket fixtures. The new DSH suite passed 5/5.A live DSH profile was not started because the
dshexecutable is not installed in this validation environment; the generated files were checked against the official bridge package contract.