fix(review): print review reject/apply output in English (#836) - #859
Merged
jeff-r2026 merged 2 commits intoSep 28, 2026
Merged
Conversation
teamai review --reject and --apply printed Chinese strings in their console output: 已拒绝 for rejected, 应用失败 for apply failed, and Chinese error reasons (缺失, 为空, 不存在, 不支持自动应用). Issue Tencent#836 established that CLI output must be English, and Tencent#840 fixed the same class of bug in cache-cmd and import-local; review-cmd was missed. Translate the six user-facing strings in applyOne's error reasons and reviewCmd's reject/apply messages. Code comments are left as-is — they are not user-facing. Add three tests that assert the English text and no CJK characters in the output; all three fail before this fix.
The domain-drift apply test in review-cmd.test.ts still asserted the Chinese string '不支持' which was translated in the previous commit. Update the assertion to match the English output.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teamai review --rejectandteamai review --applyprint Chinese strings in their console output:已拒绝for "rejected",应用失败for "apply failed", and Chinese error reasons (target.section 缺失,payload.content 为空,目标文件不存在,不支持自动应用). Issue #836 established that CLI output must be English, and #840 fixed the same class of bug incache-cmd.tsandimport-local.ts;review-cmd.tswas missed.Before:
After:
Changes
applyOne's error reasons andreviewCmd's reject/apply messagesTest
Three tests assert the English text and the absence of CJK characters in the output, following the same pattern as the cache-cmd tests added in #840. All three fail before this fix:
Real-CLI verification
Built with
npm run build(tsup, Node 22), then ran threeteamai reviewinvocations against seeded.teamai/pending-review.jsonlfixtures:All three paths print English. No CJK characters in the output.
Found by a defect-hunting pipeline I build and run (Dev-next-gen), using Claude Code with Anthropic's Claude Opus 5.