Draft improvements from assistant conversations: shipment vs. container field placement - #298
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| | `bill_of_lading_number` | `shipment` | `GET /shipments/{id}` | | ||
| | `port_of_lading_name` / `port_of_discharge_name` | `shipment` | `GET /shipments/{id}` | | ||
| | `shipping_line_scac` / `shipping_line_name` | `shipment` | `GET /shipments/{id}` | | ||
| | `ref_numbers` | `shipment` | `GET /shipments/{id}` | |
There was a problem hiding this comment.
Reference Numbers On Wrong Resource
When a developer follows this row to fetch ref_numbers, they will query the shipment endpoint even though the schema places ref_numbers on container attributes. That leaves the documented lookup path returning no reference numbers for the field this table is meant to locate.
| | `ref_numbers` | `shipment` | `GET /shipments/{id}` | | |
| | `ref_numbers` | `container` | `GET /containers/{id}` | |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/api-docs/getting-started/list-shipments-and-containers.mdx
Line: 38
Comment:
**Reference Numbers On Wrong Resource**
When a developer follows this row to fetch `ref_numbers`, they will query the shipment endpoint even though the schema places `ref_numbers` on container attributes. That leaves the documented lookup path returning no reference numbers for the field this table is meant to locate.
```suggestion
| `ref_numbers` | `container` | `GET /containers/{id}` |
```
How can I resolve this? If you propose a fix, please make it concise.| | `pod_full_out_at`, `pod_arrived_at`, `pod_discharged_at`, `empty_terminated_at`, `pickup_lfd`, `available_for_pickup` | Object with `type: "container"` → `attributes.<field>` | | ||
| | Shipment ID | Object with `type: "shipment"` → `id` | | ||
| | Bill of lading number | Object with `type: "shipment"` → `attributes.bill_of_lading_number` | | ||
| | Reference numbers (`ref_numbers`) | Object with `type: "shipment"` → `attributes.ref_numbers` | |
There was a problem hiding this comment.
Reference Numbers Read From Shipment
When webhook consumers use this extraction table, they will read ref_numbers from the included shipment object. The schema places ref_numbers on container attributes, so integrations built from this row can miss reference numbers that are present on the container.
| | Reference numbers (`ref_numbers`) | Object with `type: "shipment"` → `attributes.ref_numbers` | | |
| | Reference numbers (`ref_numbers`) | Object with `type: "container"` → `attributes.ref_numbers` | |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/api-docs/webhooks/payloads.mdx
Line: 123
Comment:
**Reference Numbers Read From Shipment**
When webhook consumers use this extraction table, they will read `ref_numbers` from the included shipment object. The schema places `ref_numbers` on container attributes, so integrations built from this row can miss reference numbers that are present on the container.
```suggestion
| Reference numbers (`ref_numbers`) | Object with `type: "container"` → `attributes.ref_numbers` |
```
How can I resolve this? If you propose a fix, please make it concise.|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Summary
Clarify which tracking fields live on the
shipmentresource versus thecontainerresource, addressing a recurring source of confusion in developer questions about ETA and milestone fields.Changes
pod_eta_at,pod_original_eta_at,destination_eta_at,pod_full_out_at,pickup_lfd, etc.) to the correct endpoint.?include=shipment.included" table in Webhook Payloads to cover container milestone fields and shipment ETA fields, with a callout linking back to the field-placement reference.Context
Multiple recent developer questions asked why
pod_eta_at/pod_original_eta_at/destination_eta_atwere missing fromGET /containersresponses, and where to find container milestone fields likepod_full_out_atin webhook payloads. The docs described these fields in scattered places but did not offer a single reference of which object owns which field.Greptile Summary
This PR clarifies where common tracking fields live in the docs. The main changes are:
include=shipmenton container requests.includedextraction guidance for ETA and milestone fields.Confidence Score: 4/5
The documentation update is close, but the
ref_numberslookup path needs a fix before merging.ref_numbersis documented as a shipment field in the guide.ref_numbersfrom the shipment object.ref_numberson container attributes, so both rows can lead integrations to the wrong object.docs/api-docs/getting-started/list-shipments-and-containers.mdx; docs/api-docs/webhooks/payloads.mdx
Important Files Changed
ref_numbersat the wrong resource.ref_numbersdocumented under the wrong included object.Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "docs: clarify shipment vs. container fie..." | Re-trigger Greptile