-
Notifications
You must be signed in to change notification settings - Fork 5
Fill gaps from assistant conversations: rail webhooks, missed events, shipments filter, map local testing #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -602,7 +602,7 @@ | |
| }, | ||
| "in": "query", | ||
| "name": "number", | ||
| "description": "Search shipments by the original request tracking `request_number`" | ||
| "description": "Search shipments by the original tracking `request_number` — typically a master bill of lading or booking number. This filter does **not** match container numbers; to look up a shipment by container number, use `GET /containers?filter[number]={container_number}` and include the related shipment via `include=shipment`." | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
A client following this description will call Prompt To Fix With AIThis is a comment left during a code review.
Path: docs/openapi.json
Line: 605
Comment:
**Container Lookup Uses Unsupported Filter**
A client following this description will call `GET /containers?filter[number]=...`, but the containers operation does not define that parameter and the typed SDK cannot emit it. The server may reject the request or ignore the filter and return a paginated list instead of the requested container; the documented cross-resource lookup for container numbers is `/search?query=...`.
How can I resolve this? If you propose a fix, please make it concise. |
||
| }, | ||
| { | ||
| "schema": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loading the hosted script and stylesheet does not prove that the embed works from
file://: requests made by the bundle use the browser'snullorigin and fail unless the map API explicitly permits it. If that API only allows normal HTTP origins, the assets load but the map remains blank, so this claim should be limited to verified origins or state the required CORS support.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!