Repository navigation
fix(security): harden MCP, SDK, CLI and workflow boundaries - #487
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
…' into fix/security-audit-followups # Conflicts: # package.json
github-actions
Bot
added
risk:unknown
dodeja
changed the title
github-actions
Bot
added
risk:high
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03e505c517
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
github-actions
Bot
added
risk:unknown
github-actions
Bot
added
risk:high
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validate caller identity before operator-key documentation search. Contain OAuth helper errors and stale refresh/login updates. Encode terminal controls in human CLI output, use private exclusive config writes, and preserve SDK cancellation through retries and body consumption. Replace live captures with deterministic synthetic public fixtures.
Pin CI actions and review-plugin inputs, validate release tags as data, separate read-only Postman validation from main-only publication, and minimize documentation analytics URL/referrer metadata. Root tests include security and fixture checks.
Scope and validation
PR #488 was merged into this branch, so this PR now includes its CI and telemetry changes. Both subsequent main updates are preserved. Latest fetched main is
29de6a6ad9e5b9ebf06f45c527a36424c2c93cb5. The current headc2c7fbe7c628a7c830f22a2c65f1367901975f44has the exact tree that passed all sevennpm run agent-verifysteps locally. Real local CLI, SDK abort, helper and stdio smoke checks passed with synthetic credentials. Independent source reviews and Claude Opus review passed after correcting alternate referrer and refresh/login handling. A separate review accepted the main-merge resolution.Human CLI control characters become visible escapes. JSON/NDJSON retains the data. SDK deadlines include response consumption, and unsafe existing config permissions are rejected.
Remaining validation
Final-head preview handshake passed, but live tool evaluation stopped at fixture discovery with upstream HTTP 401. All 32 live cases were skipped. This repeats the earlier-head failure. DEV-13958 tracks private credential/account/routing checks and rerunning the current-head gate. Other remote checks included pending jobs at handoff. The gate was not weakened. This PR is not merge-ready.
Historical-key revocation, deployed backend denial proof, npm publishing policy and native repository-rule decisions remain separate owner work. No production deployment, credential revocation or history rewrite is included. The development-only Faker/Postman advisory remains open in Dependabot #313; an isolated patched-Faker override broke legacy Postman initialization. Runtime-only audit reports zero advisories.
Review follow-up
All five original review threads on #487 and merged #488 are addressed. Restored SDK trade-intelligence response shapes and CLI demurrage/rail table contracts. Unrelated release families skip before checkout while selected/manual tags retain validation. A pinned official Segment standalone SDK test now captures initial and SPA page POST bodies with synthetic configuration and blocked external network. It also verifies the fix for an initial URL ending in undefined. The merge-commit separation thread was answered with actual scoped ancestor commits; follow-up SDK, CLI, workflow, test-tooling and docs runtime changes remain separate commits.
At
c2c7fbe7c628a7c830f22a2c65f1367901975f44, full local agent-verify passes seven steps. Independent current-head source review passes. The five original threads have replies and are resolved. Fresh remote CI still has the authenticated preview failure with upstream HTTP401; DEV-13958 remains open. Existing unchanged zod/fast-uri dependency entries now have separate follow-up DEV-14059. No merge or production deployment was performed.