Skip to content

feat(pr-walkthrough): add PR walkthrough skill#273

Merged
Terry-Mao merged 2 commits into
mainfrom
feat/support-pr-walkthrough-272
Jun 19, 2026
Merged

feat(pr-walkthrough): add PR walkthrough skill#273
Terry-Mao merged 2 commits into
mainfrom
feat/support-pr-walkthrough-272

Conversation

@Terry-Mao

Copy link
Copy Markdown
Owner

Summary

  • 新增 .agents/skills/pr-walkthrough,用于生成本地静态交互式 D3 PR walkthrough。
  • 内置 D3 HTML 生成脚本和 canvas 校验脚本,覆盖四个视图:system overview、data flow、code dependency、user action。
  • .aicodingflow/ 加入 .gitignore,避免本地生成 walkthrough 产物进入开发分支。

Validation

  • .venv/bin/python /Users/maojian/.codex/skills/.system/skill-creator/scripts/quick_validate.py .agents/skills/pr-walkthrough
  • PYTHONPYCACHEPREFIX=/private/tmp/aicodingflow-pycache .venv/bin/python -m py_compile .agents/skills/pr-walkthrough/scripts/d3_canvas_runtime.py .agents/skills/pr-walkthrough/scripts/validate_d3_canvas.py
  • .venv/bin/python .agents/skills/pr-walkthrough/scripts/validate_d3_canvas.py --html /private/tmp/pr-walkthrough-index.html --require-browser
  • git diff --check

Refs #272

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发现 2 个阻塞问题:生成的 walkthrough HTML 对不可信图数据中的链接缺少 URL scheme 校验;验证脚本也没有覆盖技能要求的 system-overview PR-agnostic 约束。

Comment thread .agents/skills/pr-walkthrough/scripts/d3_canvas_runtime.py Outdated
Comment thread .agents/skills/pr-walkthrough/scripts/validate_d3_canvas.py
@Terry-Mao

Copy link
Copy Markdown
Owner Author

@kratos-ci-bot /fix 修复所有 comments

@github-actions

Copy link
Copy Markdown
Contributor

Applied requested changes on feat/support-pr-walkthrough-272.

Summary:

Summary

  • 为 PR walkthrough D3 链接渲染增加安全 scheme 白名单,阻止 graph data 中的 javascript:/data: 等危险 href。
  • 强化 D3 canvas validator,确保 system-overview 不携带 PR 附件或 PR/diff/review/spec/comment 语境内容。
  • 新增 pr-walkthrough 脚本单元测试覆盖链接过滤和 overview 校验。

Validation

  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/aicodingflow-tests -p 'test_pr_walkthrough_scripts.py'
  • PYTHONPYCACHEPREFIX=/tmp/aicodingflow-pycache python3 -m py_compile .agents/skills/pr-walkthrough/scripts/d3_canvas_runtime.py .agents/skills/pr-walkthrough/scripts/validate_d3_canvas.py .github/aicodingflow-tests/test_pr_walkthrough_scripts.py
  • git diff --check

#273

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未发现需要阻止合并的问题。已检查新增 pr-walkthrough skill、D3 runtime、canvas validator、测试覆盖和 .gitignore 变更;先前关于不可信 URL href 与 system-overview 验证缺口的讨论已在当前 diff 中处理,未重复提出。

@Terry-Mao Terry-Mao merged commit b5e6466 into main Jun 19, 2026
3 checks passed
@Terry-Mao Terry-Mao deleted the feat/support-pr-walkthrough-272 branch June 19, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant