Conversation
|
/agentic_describe |
|
/agentic_review |
PR Summary by QodoAdd OpenPRU licensing and release manifest
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1. Package license link is broken
|
7fecd8c to
5cf9cc3
Compare
| <td><b>Location</b></td> | ||
| <td id="location" name="location"> | ||
| <span>[as installed]/*</span> | ||
| </td> |
There was a problem hiding this comment.
1. The manifest omits required attributions 🐞 Bug ≡ Correctness
The sole manifest row assigns BSD-3-Clause to [as installed]/* and reproduces only a 2022 Texas Instruments notice, although bundled files carry IBM, Google, and Dimitar Dimitrov notices and the documentation contains separate use restrictions. Distributions relying on this manifest therefore misstate the rights for those files and can omit notices their licenses require.
Agent Prompt
## Issue description
The manifest applies one BSD-3-Clause entry and one Texas Instruments copyright notice to every installed file, despite bundled files having other copyright holders and licensing restrictions.
## Fix Focus Areas
- MANIFEST.html[249-297]
- source/include/linux/pru_virtio_ring.h[7-33]
- source/include/linux/rsc_types.h[1-18]
- examples/gcc_rpmsg_echo_linux/Makefile[1-27]
- docs_ai/reference/pru_optimizing_c_compiler_users_guide_v2_3/pru_optimizing_c_compiler_users_guide_v2_3.md[5814-5832]
## Recommended Fix
Replace the root-wide license row with accurately scoped entries for each distinct component and license. Include the required IBM, Google, and Dimitar Dimitrov notices, and list the documentation separately with its applicable Texas Instruments restrictions.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Code review by qodo was updated up to the latest commit 5cf9cc3 |
Signed-off-by: Dhaval Khandla <dhavaljk@ti.com>
013e522
5cf9cc3 to
013e522
Compare
| @@ -0,0 +1 @@ | |||
| [Manifest Document Link](./MANIFEST.html) No newline at end of file | |||
There was a problem hiding this comment.
1. Package license link is broken 🐞 Bug ≡ Correctness
LICENSE.md is added as the replacement license entry point, but .metadata/.tirex/package.tirex.json still declares ../../LICENSE, which does not exist at the repository root. Any package consumer following the declared license field reaches a missing file instead of the new manifest link.
Agent Prompt
## Issue description
The new license entry point is `LICENSE.md`, but package metadata still references the nonexistent root-level `LICENSE` file.
## Fix Focus Areas
- LICENSE.md[1-1]
- .metadata/.tirex/package.tirex.json[7-10]
## Recommended Fix
Change the package metadata license path from `../../LICENSE` to `../../LICENSE.md`, or retain a root-level `LICENSE` file at the currently declared path.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Code review by qodo was updated up to the latest commit 013e522 |
No description provided.