update metrics for private designs - #4377
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD subproject commit and adjusts the baseline rules for the ariane and bp_quad designs. However, the changes introduce severe timing regressions, including a nearly 100% degradation in setup TNS at the CTS stage for ariane, a 70% increase in worst slack violation at the CTS stage for bp_quad, and more than doubled hold TNS at the finish stage for bp_quad. Rather than relaxing the baseline rules to accommodate these regressions, the root causes of the timing issues should be addressed in the tool or flow configuration.
| }, | ||
| "cts__timing__setup__tns": { | ||
| "value": -57400.0, | ||
| "value": -112000.0, |
There was a problem hiding this comment.
The setup TNS at the CTS stage has degraded significantly from -57400.0 to -112000.0 (nearly a 100% increase in total negative slack). This indicates a severe timing regression introduced by the OpenROAD subproject update. Address the root cause of this timing regression in the tool or flow configuration instead of relaxing the baseline rules.
| }, | ||
| "cts__timing__setup__ws": { | ||
| "value": -313.0, | ||
| "value": -534.0, |
| }, | ||
| "finish__timing__hold__tns": { | ||
| "value": -400.0, | ||
| "value": -818.0, |
designs/gf12/ariane/rules-base.json updates:
designs/gf12/bp_quad/rules-base.json updates: