Skip to content

update metrics for private designs - #4377

Merged
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_private_metrics
Jul 23, 2026
Merged

update metrics for private designs#4377
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_private_metrics

Conversation

@eder-matheus

Copy link
Copy Markdown
Member

designs/gf12/ariane/rules-base.json updates:

Metric Old New Type
placeopt__design__instance__area 212649 211858 Tighten
placeopt__design__instance__count__stdcell 224376 220675 Tighten
cts__design__instance__count__setup_buffer 19511 19189 Tighten
cts__design__instance__count__hold_buffer 19511 19189 Tighten
cts__timing__setup__tns -57400.0 -112000.0 Failing
globalroute__antenna_diodes_count 178 175 Tighten
detailedroute__route__wirelength 3544090 3473208 Tighten
detailedroute__antenna_diodes_count 178 175 Tighten
finish__design__instance__area 214910 214224 Tighten

designs/gf12/bp_quad/rules-base.json updates:

Metric Old New Type
placeopt__design__instance__area 1497196 1491642 Tighten
placeopt__design__instance__count__stdcell 1455380 1425603 Tighten
cts__design__instance__count__setup_buffer 126555 123966 Tighten
cts__design__instance__count__hold_buffer 126555 123966 Tighten
cts__timing__setup__ws -313.0 -534.0 Failing
cts__timing__setup__tns -638000.0 -338000.0 Tighten
globalroute__antenna_diodes_count 1107 1087 Tighten
globalroute__timing__setup__tns -8020.0 -1430.0 Tighten
globalroute__timing__hold__tns -519.0 -476.0 Tighten
detailedroute__antenna_diodes_count 1110 1090 Tighten
finish__timing__setup__ws -208.0 -203.0 Tighten
finish__timing__hold__tns -400.0 -818.0 Failing

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@eder-matheus eder-matheus self-assigned this Jul 23, 2026
@eder-matheus
eder-matheus requested a review from maliberty July 23, 2026 17:36

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenROAD subproject commit and adjusts the baseline rules for the ariane and bp_quad designs. However, the changes introduce severe timing regressions, including a nearly 100% degradation in setup TNS at the CTS stage for ariane, a 70% increase in worst slack violation at the CTS stage for bp_quad, and more than doubled hold TNS at the finish stage for bp_quad. Rather than relaxing the baseline rules to accommodate these regressions, the root causes of the timing issues should be addressed in the tool or flow configuration.

},
"cts__timing__setup__tns": {
"value": -57400.0,
"value": -112000.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The setup TNS at the CTS stage has degraded significantly from -57400.0 to -112000.0 (nearly a 100% increase in total negative slack). This indicates a severe timing regression introduced by the OpenROAD subproject update. Address the root cause of this timing regression in the tool or flow configuration instead of relaxing the baseline rules.

},
"cts__timing__setup__ws": {
"value": -313.0,
"value": -534.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The worst slack (WS) at the CTS stage has degraded significantly from -313.0 to -534.0 (a 70% increase in slack violation). Address the root cause of this timing regression in the tool or flow configuration instead of relaxing the baseline rules.

},
"finish__timing__hold__tns": {
"value": -400.0,
"value": -818.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The hold TNS at the finish stage has degraded from -400.0 to -818.0 (more than doubling the total negative slack). Address the root cause of this timing regression in the tool or flow configuration instead of relaxing the baseline rules.

@maliberty
maliberty enabled auto-merge July 23, 2026 17:57
@maliberty
maliberty merged commit 0b1abc5 into The-OpenROAD-Project:master Jul 23, 2026
8 checks passed
@maliberty
maliberty deleted the update_private_metrics branch July 23, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants