gui: add an option for arrow keys scroll acceleration#10983
Open
SquareRobin wants to merge 5 commits into
Open
gui: add an option for arrow keys scroll acceleration#10983SquareRobin wants to merge 5 commits into
SquareRobin wants to merge 5 commits into
Conversation
Signed-off-by: Igor Sokolov <disk.destroyer@yahoo.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an option to enable scroll acceleration when using arrow keys in the GUI layout viewer. It propagates the new configuration option through the MainWindow, LayoutTabs, and LayoutScroll classes, and implements the acceleration logic in LayoutScroll's key press event handler. The review feedback suggests aligning the newly added member variables and constants with the project's naming conventions (using snake_case_ and kCamelCase). Additionally, it recommends refining the acceleration logic by using floating-point division with rounding to prevent abrupt jumps caused by integer division, and resetting the acceleration counter when the active scroll key changes.
added 4 commits
July 24, 2026 17:53
Signed-off-by: Igor Sokolov <disk.destroyer@yahoo.com>
switch to float with static_cast to int in the multiplier calculation Signed-off-by: Igor Sokolov <disk.destroyer@yahoo.com>
Signed-off-by: Igor Sokolov <disk.destroyer@yahoo.com>
Signed-off-by: Igor Sokolov <disk.destroyer@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scrolling with the arrow keys is convenient, but the acceleration is controlled only by the system. Adding an option for acceleration does not overcomplicate the settings and makes arrow keys scrolling a bit more practical.
Testing with different key repeat settings did not reveal any problems related to different auto-repeat frequencies and delays.
Type of Change
Impact
Adds a checkbox to the "Options" menu.
Verification
./etc/Build.sh).